fix(guardrails): vision-bridge DI gap + capability-gated stub + stale 7859 mock (#9541) - #9546
Closed
diegosouzapw wants to merge 4 commits into
Closed
diegosouzapw wants to merge 4 commits into
diegosouzapw wants to merge 4 commits into
Conversation
… 7859 mock (#9541) Three deterministic fast-path shard reds on every code PR since 2026-08-04: 1. visionBridge.ts did not thread its injected hasUsableCredentials into getBestVisionModel(), so #8430's fixedModel validation ran the REAL DB check even under test DI — an empty credential store (CI) silently disabled the whole reroute path (VB-S12/S12b/S01/S13/S07/S10 red on every PR, including docs-only). 2. #8430's all-describes-failed stub replaced raw images even for a CONFIRMED vision-capable upstream forced through the combo path, violating the #4012 preserve contract (VB-S03). The stub is now gated on the upstream NOT being vision-capable — exactly the case #8430's own rationale covers. 3. The #7859 regression test mocked its public redirect as accounts.google.com/ServiceLogin, which #9407 has since redefined as an EXPIRED session — the mock now uses a non-ServiceLogin public target, keeping both contracts covered by their own tests. Validated with the CI loader set (isolateDataDir): visionBridge 25/25, vision-bridge-preserve-4012 + repro-8430 5/5, 7859+9407 12/12, typecheck:core clean.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the three deterministic
Unit Tests fast-pathshard reds hitting every code PR since 2026-08-04 (Refs #9541 — the load-dependent D1/D2 half was fixed by #9385):visionBridge.tsdidn't thread its injectedhasUsableCredentialsintogetBestVisionModel()— fix(providers): Vision Bridge describe-model unreachable when no openai provider connected → raw image forwarded to non-vision model #8430's fixedModel validation ran the real DB check under test DI, so CI's empty credential store silently disabled the reroute path (VB-S12/S01/… red on every PR, docs-only included).ServiceLogin, which fix(providers): gemini-web connection test false-positives while 15s queue masks failures #9407 redefined as expired-session — moved to a non-ServiceLogin public target; both contracts keep dedicated coverage.Validation (CI loader set): visionBridge 25/25 · 4012+8430 5/5 · 7859+9407 12/12 · typecheck clean. This PR's own fast-path shards double as the live proof.