Skip to content

fix(ci): merge-queue tolerance for Build (advisory), drops paid-tier batching - #9233

Merged
diegosouzapw merged 3 commits into
diegosouzapw:release/v3.8.50from
wgordon17:fix/mergify-queue-tolerance-regression
Aug 4, 2026
Merged

diegosouzapw merged 3 commits into
diegosouzapw:release/v3.8.50from
wgordon17:fix/mergify-queue-tolerance-regression

Conversation

@wgordon17

@wgordon17 wgordon17 commented Aug 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

@wgordon17
wgordon17 marked this pull request as ready for review August 2, 2026 16:44
@wgordon17
wgordon17 requested a review from diegosouzapw as a code owner August 2, 2026 16:44
@mergify

mergify Bot commented Aug 2, 2026

Copy link
Copy Markdown

Merge Protections

🟢 Merge protection satisfied — ready to merge.

Show 1 satisfied protection

🟢 📃 Configuration Change Requirements

Mergify configuration change

  • check-success = Configuration changed

@wgordon17 wgordon17 changed the title fix(ci): restores dast-smoke queue tolerance, drops batching fix(ci): merge-queue tolerance for Build (advisory), drops paid-tier batching Aug 2, 2026
PR diegosouzapw#7329 (an unrelated cliproxy feature PR) silently reverted two prior
Mergify fixes when it touched .mergify.yml from a stale branch:

- diegosouzapw#7225's tolerance for the advisory dast-smoke check, which hangs
  recurrently on GitHub-hosted runners (issue diegosouzapw#7226) and had been
  dequeuing every queue attempt it touched.
- diegosouzapw#7220's removal of batch_size/batch_max_wait_time, which is a paid
  Mergify tier feature this repo's free plan does not have (the queue
  command fails outright with it set).

Restores both fixes verbatim. No PR has used the queue label since
diegosouzapw#7329 landed two weeks ago, so this had gone unnoticed.
The first pass of this fix missed a second piece diegosouzapw#7329 clobbered in
the same diff hunk: merge_protections_settings.auto_merge_conditions,
the actual mechanism that puts a queue-labeled PR into the queue (the
older rules-based autoqueue path it replaced is EOL). Without it, the
queue label was a no-op even after restoring the check-failure
tolerance and dropping batching.

.mergify.yml now matches commit 9875ccf (the last known-good state
before diegosouzapw#7329) byte-for-byte, confirmed via sha256.
Evidence review found the prior fix's dast-smoke exception is stale:
dast-smoke has failed only twice ever, none since 2026-07-13 (0/30 in
the last ~3.3h across many PRs). Meanwhile Build (advisory), added to
quality.yml 2026-07-27, has a 100% failure rate on every sampled PR
since — confirmed via job logs to be the same class of runner hang
(dies mid "Creating an optimized production build", never a real
compile error), just in a check dast-smoke's tolerance never covered.

Retargets the merge_conditions exception accordingly so the queue can
actually tolerate the failure mode it faces today, instead of one
that's been dormant for weeks.
@wgordon17
wgordon17 force-pushed the fix/mergify-queue-tolerance-regression branch from 392503f to af54c58 Compare August 2, 2026 18:42
@diegosouzapw
diegosouzapw merged commit 2e42680 into diegosouzapw:release/v3.8.50 Aug 4, 2026
16 of 17 checks passed
@diegosouzapw

Copy link
Copy Markdown
Owner

Merged — thanks @wgordon17.

Your diagnosis matched an independent measurement I ran while triaging the queue today: of 149 merge-ready candidates, 21 were failing on Build (advisory) and nothing else — Fast Quality Gates, all four Unit Tests shards, Vitest and Merge integrity were green on every one of them. The job log confirms the cause you documented (run 30768479406): Turbopack enters "Creating an optimized production build", runs ~7 minutes, then The runner has received a shutdown signal → The operation was canceled. Never a compile error.

Also appreciated that you dropped the stale dast-smoke exception instead of carrying it forward, and kept the anti-fail-open shape (any other failure still blocks). This unblocks the rest of the queue.

muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…batching (diegosouzapw#9233)

* fix(ci): restores dast-smoke queue tolerance, drops batching

PR diegosouzapw#7329 (an unrelated cliproxy feature PR) silently reverted two prior
Mergify fixes when it touched .mergify.yml from a stale branch:

- diegosouzapw#7225's tolerance for the advisory dast-smoke check, which hangs
  recurrently on GitHub-hosted runners (issue diegosouzapw#7226) and had been
  dequeuing every queue attempt it touched.
- diegosouzapw#7220's removal of batch_size/batch_max_wait_time, which is a paid
  Mergify tier feature this repo's free plan does not have (the queue
  command fails outright with it set).

Restores both fixes verbatim. No PR has used the queue label since
diegosouzapw#7329 landed two weeks ago, so this had gone unnoticed.

* fix(ci): restores the auto-enqueue merge_protections_settings block

The first pass of this fix missed a second piece diegosouzapw#7329 clobbered in
the same diff hunk: merge_protections_settings.auto_merge_conditions,
the actual mechanism that puts a queue-labeled PR into the queue (the
older rules-based autoqueue path it replaced is EOL). Without it, the
queue label was a no-op even after restoring the check-failure
tolerance and dropping batching.

.mergify.yml now matches commit 0011f0f (the last known-good state
before diegosouzapw#7329) byte-for-byte, confirmed via sha256.

* fix(ci): retargets queue tolerance from dast-smoke to Build (advisory)

Evidence review found the prior fix's dast-smoke exception is stale:
dast-smoke has failed only twice ever, none since 2026-07-13 (0/30 in
the last ~3.3h across many PRs). Meanwhile Build (advisory), added to
quality.yml 2026-07-27, has a 100% failure rate on every sampled PR
since — confirmed via job logs to be the same class of runner hang
(dies mid "Creating an optimized production build", never a real
compile error), just in a check dast-smoke's tolerance never covered.

Retargets the merge_conditions exception accordingly so the queue can
actually tolerate the failure mode it faces today, instead of one
that's been dormant for weeks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants