Skip to content

fix(sse): brand-neutral keepalive frames - #8888

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.50from
AndrianBalanescu:fix/neutral-sse-keepalive
Aug 6, 2026
Merged

diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.50from
AndrianBalanescu:fix/neutral-sse-keepalive

Conversation

@AndrianBalanescu

@AndrianBalanescu AndrianBalanescu commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Replace client-visible SSE keepalive/startup brand placeholders (OmniRoute: got request…, model:omniroute, omniroute-keepalive) with neutral tokens (✨, chatcmpl-keepalive, model:keepalive).
  • Keep heartbeat behavior unchanged so short idle-read clients still stay connected during slow first-byte paths.

Test plan

  • node --import tsx/esm --test tests/unit/early-stream-keepalive.test.ts tests/unit/combo-test-health.test.ts tests/unit/sse-heartbeat-integration.test.ts (30/30)
  • Smoke a slow Responses-API stream and confirm reasoning startup text is ✨ (no product name)
  • Smoke Chat Completions keepalive chunk id/model are brand-neutral

Client-visible SSE startup/keepalive frames were embedding product-name
placeholders into reasoning UIs and stream logs. Use neutral tokens instead
while preserving heartbeat behavior for short idle-read clients.
@diegosouzapw
diegosouzapw merged commit 48b5c7f into diegosouzapw:release/v3.8.50 Aug 6, 2026
5 checks passed
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
Validated in local merge-train T4 (HouMinXi+Zartharas+Andrian+artickc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants