Skip to content

fix(adobe-firefly): cap gpt-image refs at 2 + adaptive poll timeout - #8870

Merged
diegosouzapw merged 3 commits into
diegosouzapw:release/v3.8.50from
artickc:fix/adobe-firefly-gpt-ref-cap-timeout
Aug 6, 2026
Merged

diegosouzapw merged 3 commits into
diegosouzapw:release/v3.8.50from
artickc:fix/adobe-firefly-gpt-ref-cap-timeout

Conversation

@artickc

@artickc artickc commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Problem

Featured Promo / Box Art (and similar multi-screenshot listing jobs) failed with:

504 - Adobe Firefly image generation timed out

Live call logs: adobe-firefly/gpt-image-2, wall clock ~190–231s, error timeout after the 180s poll budget.

Prompts say "all 5 attached screenshots". gpt-image uses referenceBlobs with usage: "subject". Colligo is reliable with 1–2 subject refs; 3–4+ commonly hang until poll 504.

Fix

  1. Cap gpt-image family to 2 subject refs (upload + payload). Nano keeps 4 general refs for multi-panel composition.
  2. Default poll timeout 180s → 300s, plus +60s per ref (cap 600s). Explicit timeout_ms still wins.
  3. Defensive .slice() in buildAdobeImagePayload so oversized id lists cannot re-inflate the wire body.

Tests

Unit coverage for ref caps + adaptive timeout (main tree 47/47 adobe-firefly suite).

Note for listing pipelines

For multi-panel Store art with 4–5 screenshots prefer nano-banana (multi-ref general). gpt-image-2 is better for 0–2 subject refs + max detailLevel.

…eout

Store listing jobs (Featured Promo / Box Art) attach 5 screenshots to
gpt-image-2. Subject referenceBlobs beyond 1-2 stall colligo until the
180s poll budget expires (HTTP 504). Cap gpt-image to 2 subject refs
(nano keeps 4 general), raise default poll to 5 min, and add +60s per
ref (max 10 min). Explicit timeout_ms still wins.
@artickc
artickc requested a review from diegosouzapw as a code owner July 28, 2026 17:56
…+63)

File-size gate frozen 2322->2385 for PR diegosouzapw#8870: subject-ref cap + adaptive
poll timeout. Documented under _rebaseline_2026_07_28_8870_firefly_ref_cap_timeout.
@diegosouzapw
diegosouzapw changed the base branch from release/v3.8.49 to release/v3.8.50 July 28, 2026 18:39
@diegosouzapw

Copy link
Copy Markdown
Owner

Re-homed to release/v3.8.50: v3.8.49 entered its release freeze, so the branch now belongs to the release captain and development continues on the next cycle. Nothing is wrong with this PR — it just needed a live base. No action needed from you; CI will re-run against the new base.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
@diegosouzapw
diegosouzapw merged commit 4f89f2b into diegosouzapw:release/v3.8.50 Aug 6, 2026
4 of 5 checks passed
@diegosouzapw diegosouzapw mentioned this pull request Aug 23, 2026
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…iegosouzapw#8870)

Validated in local merge-train T4 (HouMinXi+Zartharas+Andrian+artickc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants