Repository navigation
fix(providers): correct Codex GPT-5.6 context window - #8838
Merged
diegosouzapw merged 3 commits intoJul 28, 2026
Merged
diegosouzapw merged 3 commits into
diegosouzapw merged 3 commits into
Conversation
Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
Three suites assert the pinned GPT_5_6_CODEX_CAPABILITIES contract through the VS Code and provider-models routes, and still expected 372000. They only surface in a full run, so the focused loop on this PR stayed green while `npm run test:unit` failed with five `272000 !== 372000`. The two conservative-merge cases in provider-models-route-codex keep testing what they tested: live 999999 still exceeds the pinned value (pinned wins) and live 100000 is still below it (live wins). Only the pinned number and the comments naming it move. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
diegosouzapw
added a commit
that referenced
this pull request
Jul 28, 2026
…e lost credits Aggregates every pending changelog.d fragment into the [3.8.49] section and regenerates the contributors table from the reconciled bullets. Three fixes this surfaced: - The [3.8.49] section had no `### 📝 Maintenance` heading, so the aggregator's findIndex matched the first one in the file — inside [3.8.47] — and would have filed 92 maintenance bullets under the wrong release. Added the heading to the living section; [3.8.47] stays at its original 234 bullets. - 46 bullets carried no PR/issue reference. Fragments may keep the number only in the filename (`<N>-slug.md`), which the aggregator does not copy into the bullet, so the link and the credit were dropped on aggregation. Restored, scoped strictly to the [3.8.49] range. - 9 external contributors lost their attribution that way and are credited again: @MisileLab (#8566), @MumuTW (#8619), @epsilonode (#8724), @hppsc1215 (#8835), @sumanxg (#8837, #8856), @TitoTFP (#8838), @HouMinXi (#8842, #8845). Contributors table: 84 → 155 entries, no one removed. 42 i18n mirrors synced. check:changelog-integrity green — no base bullet lost.
Merged
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
* fix(providers): correct Codex GPT-5.6 context window (diegosouzapw#7702) * docs(changelog): add fragment for diegosouzapw#8838 Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> * test(providers): align the remaining GPT-5.6 context-window assertions Three suites assert the pinned GPT_5_6_CODEX_CAPABILITIES contract through the VS Code and provider-models routes, and still expected 372000. They only surface in a full run, so the focused loop on this PR stayed green while `npm run test:unit` failed with five `272000 !== 372000`. The two conservative-merge cases in provider-models-route-codex keep testing what they tested: live 999999 still exceeds the pinned value (pinned wins) and live 100000 is still below it (live wins). Only the pinned number and the comments naming it move. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…e lost credits Aggregates every pending changelog.d fragment into the [3.8.49] section and regenerates the contributors table from the reconciled bullets. Three fixes this surfaced: - The [3.8.49] section had no `### 📝 Maintenance` heading, so the aggregator's findIndex matched the first one in the file — inside [3.8.47] — and would have filed 92 maintenance bullets under the wrong release. Added the heading to the living section; [3.8.47] stays at its original 234 bullets. - 46 bullets carried no PR/issue reference. Fragments may keep the number only in the filename (`<N>-slug.md`), which the aggregator does not copy into the bullet, so the link and the credit were dropped on aggregation. Restored, scoped strictly to the [3.8.49] range. - 9 external contributors lost their attribution that way and are credited again: @MisileLab (diegosouzapw#8566), @MumuTW (diegosouzapw#8619), @epsilonode (diegosouzapw#8724), @hppsc1215 (diegosouzapw#8835), @sumanxg (diegosouzapw#8837, diegosouzapw#8856), @TitoTFP (diegosouzapw#8838), @HouMinXi (diegosouzapw#8842, diegosouzapw#8845). Contributors table: 84 → 155 entries, no one removed. 42 i18n mirrors synced. check:changelog-integrity green — no base bullet lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
372000to the current upstream272000context window.Related Issues
Validation
Run only the focused loop for what you changed — the full unit suite, Vitest, the
60% coverage gate, and the production build all run in CI on this PR (#8329):
node --import tsx/esm --test tests/unit/codex-gpt56-catalog.test.ts tests/unit/gpt-max-input-tokens-6191.test.tsnpm run lintTests Added Or Updated
tests/unit/codex-gpt56-catalog.test.tsto pincontextLengthandmaxInputTokensat272000for every registered Codex GPT-5.6 variant.Coverage Notes
tests/unit/codex-gpt56-catalog.test.tsdirectly exercises every registry entry usingGPT_5_6_CODEX_CAPABILITIES.Reviewer Notes
372000to272000in openai/codex@d26a9bf and shipped the correction in Codex0.144.6.