fix(resilience,translator): three base-red regressions + eslint baseline — conflict resolved by herjarsa · Pull Request #8482 · diegosouzapw/OmniRoute

herjarsa · 2026-07-24T21:43:59Z

Conflict-resolved rebase of upstream PR #8254. Cherry-picked 22073c7 onto latest upstream/release/v3.8.49. Conflicts resolved:

accountFallback.ts: exactCooldownVerified → exactCooldownIsUpstreamReset rename
combo.ts: same rename + lockoutHintVerified → lockoutHintMs comparison logic
reasoningPlaceholder.ts: updated stripInternalReasoningPlaceholder logic
spawn-capable-prefixes test: removed stale comment

…s + eslint baseline — conflict resolved

….8.49 `check:file-size` fails on release/v3.8.49 at its own HEAD (36f8fd1), which is what turns `Fast Quality Gates` red for every PR against this base: tokenHealthCheck.ts 832 -> 841 chat.ts 1865 -> 1866 auth.ts 2475 -> 2486 accountFallback.ts 1941 -> 1960 combo.ts 3630 -> 3642 None of these files is touched by this PR. The growth was inherited from already merged PRs that did not bump their entries, so there is no offending branch left to fix — the same situation the baseline already records under `_rebaseline_2026_07_02_5798_release_green`, and the procedure it documents is to raise the frozen values with a justification note. Raised to the current base values only. The files stay frozen and cannot grow further; an in-flight PR that adds lines to them bumps its own entry as usual (diegosouzapw#8482 touches accountFallback.ts and combo.ts and will need that).

diegosouzapw · 2026-07-25T03:31:52Z

Thanks for taking the time to rebase this and resolve the conflicts — that work is genuinely useful, and I checked that you preserved the original commit authorship rather than re-attributing it.

Here's how we're going to land it, though. #8254 (by @diegosouzapw) is still open and is the PR that carries this change originally. If we merge this one instead, GitHub gives the "Merged" badge here and leaves #8254 stranded — the original author ends up with no credit for work that is theirs. Our contributing policy is to resolve conflicts inside the original author's branch and merge that PR.

So we'll apply your conflict resolution to #8254 and merge it there. This PR is labelled duplicate and stays open for now — we won't close it without the maintainer's explicit call.

To be clear: this is not a rejection of your work. The rebase you did is exactly what #8254 needed, and it's what will get pushed there. Thank you.

* test(sse): repair two base-red gates on release/v3.8.49 `release/v3.8.49` is red at its own HEAD (36f8fd1) — `Quality Gates` and `Release-Green (continuous)` both fail — so every PR opened against it inherits four failing checks regardless of content. Two of those causes had no owner: #8480/#8481/#8482 cover the compression ladder, the antigravity catalog, and the resilience/translator regressions respectively, none of them these. 1. `chatcore-client-usage-buffer.test.ts` — 5/5 failing. #8331/#8356 (e871978) inserted an `options` parameter between `clientResponseFormat` and `deps` on `applyClientUsageBuffer()`. The five call sites here still passed `deps` in the fourth position, so the injected spies landed in the `options` slot and the real implementations ran — every `calls.*.length` assertion saw 0. The `Parameters<typeof applyClientUsageBuffer>[3]` cast in `makeDeps()` masked the type error, which is why it reached the branch. Call sites updated to `(resp, body, format, {}, deps)` and the cast repointed to `[4]`. Two cases added for the parameter that caused this, since nothing at this layer exercised it: `preserveContextBudgetInVisibleUsage` re-folds `context_budget_*` into the visible fields for the Claude-Code path, and the default path keeps the real unbuffered #8331 numbers. 2. `claude-to-openai-think-close-5123.test.ts` — 4 unsuppressed `@typescript-eslint/no-explicit-any` errors, failing `npm run lint`. Its suppression entry allows `count: 2` but the file had grown to four `(chunk: any)` callbacks. Rather than raise the frozen count, the cause is fixed: `collectChunks()` returns `StreamChunk[]` instead of `unknown[]`, narrowing once at the boundary so all four callbacks need no annotation. The suppression entry is then stale and removed, which ratchets the file to zero. Test-only plus one allowlist deletion; no production code. Verified on a clean worktree of the base commit: `npm run lint` clean (was 4 errors), `chatcore-client-usage-buffer` 7/7 (was 0/5), `claude-to-openai-think-close-5123` 3/3. * chore(ci): rebaseline five inherited file-size overages on release/v3.8.49 `check:file-size` fails on release/v3.8.49 at its own HEAD (36f8fd1), which is what turns `Fast Quality Gates` red for every PR against this base: tokenHealthCheck.ts 832 -> 841 chat.ts 1865 -> 1866 auth.ts 2475 -> 2486 accountFallback.ts 1941 -> 1960 combo.ts 3630 -> 3642 None of these files is touched by this PR. The growth was inherited from already merged PRs that did not bump their entries, so there is no offending branch left to fix — the same situation the baseline already records under `_rebaseline_2026_07_02_5798_release_green`, and the procedure it documents is to raise the frozen values with a justification note. Raised to the current base values only. The files stay frozen and cannot grow further; an in-flight PR that adds lines to them bumps its own entry as usual (#8482 touches accountFallback.ts and combo.ts and will need that). * chore(ci): register 11 covering unit tests in stryker tap.testFiles `check:mutation-test-coverage --strict` fails on release/v3.8.49 at its own HEAD: 11 unit tests that cover mutated modules are absent from `stryker.conf.json` `tap.testFiles`, so their mutant kills do not count. The gate does not self-heal — it names the exact files to add. open-sse/services/accountFallback.ts + 8247-accountfallback-model-unhealthy, 8248-accountfallback-nvidia-degraded, model-lockout-exact-cooldown-cap, repro-antigravity-404-family-cooldown-hijack src/sse/services/auth.ts + 7993-noauth-proxy-routing, 8200-perplexity-web-401-cooldown, sse-auth-antigravity-credits src/server/authz/routeGuard.ts + authz/route-guard-vnc-session-local-only open-sse/utils/error.ts + error-sensitive-redaction open-sse/utils/publicCreds.ts + adobe-firefly src/shared/utils/circuitBreaker.ts + 8332-combo-vision-fallback None is a file this PR touches, and the gate reports the identical 11 on a worktree carrying none of these base-red fixes. Additions only (11 insertions, 0 deletions); the array stays sorted. This widens what the mutation run accounts for rather than relaxing anything. * chore(ci): re-measure accountFallback.ts file-size cap against the current base tip The entry frozen in this PR (1960) was the value at 36f8fd1; the base has since advanced to 1cafd32 and the file is 1966 there, so check:file-size would still have been red on the merge commit. Re-measured to 1966. Same inherited drift the note already documents: check:file-size does not run on the PR->release fast path, so growth accrues unmeasured between release rebaselines. The other four entries still match the current tip (tokenHealthCheck 841, chat 1866, auth 2486, combo frozen 3642 >= 3640). --------- Co-authored-by: backryun <busan011@ormbiz.co.kr>

diegosouzapw · 2026-07-25T08:26:45Z

Correcting my earlier note on this PR: after re-checking against the current release tip, two of the four changes here are indeed already covered elsewhere (the eslint-suppressions entry — that file has no any left to suppress — and the vnc-session test comment, which would actually undo something already merged), so I was right to flag those. But the other two changes — the accountFallback.ts/combo.ts cooldown-verification rename and the reasoningPlaceholder.ts trim fix — are genuine fixes that are NOT yet on the tip. Sorry for the back-and-forth; could you drop the two already-landed hunks and keep the other two? Happy to help get it across the line.

diegosouzapw · 2026-07-28T00:46:14Z

Closing — all three base-red fixes already landed via #8254

Thanks for the rebase. Verified against origin/release/v3.8.49 before closing, checking each of the three fixes:

open-sse/services/accountFallback.ts and open-sse/services/combo.ts already use the renamed exactCooldownIsUpstreamReset (2 occurrences each) — the old exactCooldownVerified is gone.
reasoningPlaceholder.ts already carries the updated stripInternalReasoningPlaceholder.
spawn-capable-prefixes-client-safe.test.ts already has the stale comment removed.

These landed through the original PR #8254 (merged in 7faec933).

One entry from your diff genuinely is not on the tip: the eslint-suppressions.json entry for oauth-refresh-connection-dedup-8059.test.ts. That is intentional and harmless — the file no longer contains any, so there is nothing left to suppress. An orphan suppression would itself be flagged by the stale-enforcement gate.

Closing as already-merged.

…#8490) * test(sse): repair two base-red gates on release/v3.8.49 `release/v3.8.49` is red at its own HEAD (d61504d) — `Quality Gates` and `Release-Green (continuous)` both fail — so every PR opened against it inherits four failing checks regardless of content. Two of those causes had no owner: diegosouzapw#8480/diegosouzapw#8481/diegosouzapw#8482 cover the compression ladder, the antigravity catalog, and the resilience/translator regressions respectively, none of them these. 1. `chatcore-client-usage-buffer.test.ts` — 5/5 failing. diegosouzapw#8331/diegosouzapw#8356 (f698fec) inserted an `options` parameter between `clientResponseFormat` and `deps` on `applyClientUsageBuffer()`. The five call sites here still passed `deps` in the fourth position, so the injected spies landed in the `options` slot and the real implementations ran — every `calls.*.length` assertion saw 0. The `Parameters<typeof applyClientUsageBuffer>[3]` cast in `makeDeps()` masked the type error, which is why it reached the branch. Call sites updated to `(resp, body, format, {}, deps)` and the cast repointed to `[4]`. Two cases added for the parameter that caused this, since nothing at this layer exercised it: `preserveContextBudgetInVisibleUsage` re-folds `context_budget_*` into the visible fields for the Claude-Code path, and the default path keeps the real unbuffered diegosouzapw#8331 numbers. 2. `claude-to-openai-think-close-5123.test.ts` — 4 unsuppressed `@typescript-eslint/no-explicit-any` errors, failing `npm run lint`. Its suppression entry allows `count: 2` but the file had grown to four `(chunk: any)` callbacks. Rather than raise the frozen count, the cause is fixed: `collectChunks()` returns `StreamChunk[]` instead of `unknown[]`, narrowing once at the boundary so all four callbacks need no annotation. The suppression entry is then stale and removed, which ratchets the file to zero. Test-only plus one allowlist deletion; no production code. Verified on a clean worktree of the base commit: `npm run lint` clean (was 4 errors), `chatcore-client-usage-buffer` 7/7 (was 0/5), `claude-to-openai-think-close-5123` 3/3. * chore(ci): rebaseline five inherited file-size overages on release/v3.8.49 `check:file-size` fails on release/v3.8.49 at its own HEAD (d61504d), which is what turns `Fast Quality Gates` red for every PR against this base: tokenHealthCheck.ts 832 -> 841 chat.ts 1865 -> 1866 auth.ts 2475 -> 2486 accountFallback.ts 1941 -> 1960 combo.ts 3630 -> 3642 None of these files is touched by this PR. The growth was inherited from already merged PRs that did not bump their entries, so there is no offending branch left to fix — the same situation the baseline already records under `_rebaseline_2026_07_02_5798_release_green`, and the procedure it documents is to raise the frozen values with a justification note. Raised to the current base values only. The files stay frozen and cannot grow further; an in-flight PR that adds lines to them bumps its own entry as usual (diegosouzapw#8482 touches accountFallback.ts and combo.ts and will need that). * chore(ci): register 11 covering unit tests in stryker tap.testFiles `check:mutation-test-coverage --strict` fails on release/v3.8.49 at its own HEAD: 11 unit tests that cover mutated modules are absent from `stryker.conf.json` `tap.testFiles`, so their mutant kills do not count. The gate does not self-heal — it names the exact files to add. open-sse/services/accountFallback.ts + 8247-accountfallback-model-unhealthy, 8248-accountfallback-nvidia-degraded, model-lockout-exact-cooldown-cap, repro-antigravity-404-family-cooldown-hijack src/sse/services/auth.ts + 7993-noauth-proxy-routing, 8200-perplexity-web-401-cooldown, sse-auth-antigravity-credits src/server/authz/routeGuard.ts + authz/route-guard-vnc-session-local-only open-sse/utils/error.ts + error-sensitive-redaction open-sse/utils/publicCreds.ts + adobe-firefly src/shared/utils/circuitBreaker.ts + 8332-combo-vision-fallback None is a file this PR touches, and the gate reports the identical 11 on a worktree carrying none of these base-red fixes. Additions only (11 insertions, 0 deletions); the array stays sorted. This widens what the mutation run accounts for rather than relaxing anything. * chore(ci): re-measure accountFallback.ts file-size cap against the current base tip The entry frozen in this PR (1960) was the value at d61504d; the base has since advanced to 59ef81b and the file is 1966 there, so check:file-size would still have been red on the merge commit. Re-measured to 1966. Same inherited drift the note already documents: check:file-size does not run on the PR->release fast path, so growth accrues unmeasured between release rebaselines. The other four entries still match the current tip (tokenHealthCheck 841, chat 1866, auth 2486, combo frozen 3642 >= 3640). --------- Co-authored-by: backryun <busan011@ormbiz.co.kr>

…#8490) * test(sse): repair two base-red gates on release/v3.8.49 `release/v3.8.49` is red at its own HEAD (75eb952) — `Quality Gates` and `Release-Green (continuous)` both fail — so every PR opened against it inherits four failing checks regardless of content. Two of those causes had no owner: diegosouzapw#8480/diegosouzapw#8481/diegosouzapw#8482 cover the compression ladder, the antigravity catalog, and the resilience/translator regressions respectively, none of them these. 1. `chatcore-client-usage-buffer.test.ts` — 5/5 failing. diegosouzapw#8331/diegosouzapw#8356 (d4ab3af) inserted an `options` parameter between `clientResponseFormat` and `deps` on `applyClientUsageBuffer()`. The five call sites here still passed `deps` in the fourth position, so the injected spies landed in the `options` slot and the real implementations ran — every `calls.*.length` assertion saw 0. The `Parameters<typeof applyClientUsageBuffer>[3]` cast in `makeDeps()` masked the type error, which is why it reached the branch. Call sites updated to `(resp, body, format, {}, deps)` and the cast repointed to `[4]`. Two cases added for the parameter that caused this, since nothing at this layer exercised it: `preserveContextBudgetInVisibleUsage` re-folds `context_budget_*` into the visible fields for the Claude-Code path, and the default path keeps the real unbuffered diegosouzapw#8331 numbers. 2. `claude-to-openai-think-close-5123.test.ts` — 4 unsuppressed `@typescript-eslint/no-explicit-any` errors, failing `npm run lint`. Its suppression entry allows `count: 2` but the file had grown to four `(chunk: any)` callbacks. Rather than raise the frozen count, the cause is fixed: `collectChunks()` returns `StreamChunk[]` instead of `unknown[]`, narrowing once at the boundary so all four callbacks need no annotation. The suppression entry is then stale and removed, which ratchets the file to zero. Test-only plus one allowlist deletion; no production code. Verified on a clean worktree of the base commit: `npm run lint` clean (was 4 errors), `chatcore-client-usage-buffer` 7/7 (was 0/5), `claude-to-openai-think-close-5123` 3/3. * chore(ci): rebaseline five inherited file-size overages on release/v3.8.49 `check:file-size` fails on release/v3.8.49 at its own HEAD (75eb952), which is what turns `Fast Quality Gates` red for every PR against this base: tokenHealthCheck.ts 832 -> 841 chat.ts 1865 -> 1866 auth.ts 2475 -> 2486 accountFallback.ts 1941 -> 1960 combo.ts 3630 -> 3642 None of these files is touched by this PR. The growth was inherited from already merged PRs that did not bump their entries, so there is no offending branch left to fix — the same situation the baseline already records under `_rebaseline_2026_07_02_5798_release_green`, and the procedure it documents is to raise the frozen values with a justification note. Raised to the current base values only. The files stay frozen and cannot grow further; an in-flight PR that adds lines to them bumps its own entry as usual (diegosouzapw#8482 touches accountFallback.ts and combo.ts and will need that). * chore(ci): register 11 covering unit tests in stryker tap.testFiles `check:mutation-test-coverage --strict` fails on release/v3.8.49 at its own HEAD: 11 unit tests that cover mutated modules are absent from `stryker.conf.json` `tap.testFiles`, so their mutant kills do not count. The gate does not self-heal — it names the exact files to add. open-sse/services/accountFallback.ts + 8247-accountfallback-model-unhealthy, 8248-accountfallback-nvidia-degraded, model-lockout-exact-cooldown-cap, repro-antigravity-404-family-cooldown-hijack src/sse/services/auth.ts + 7993-noauth-proxy-routing, 8200-perplexity-web-401-cooldown, sse-auth-antigravity-credits src/server/authz/routeGuard.ts + authz/route-guard-vnc-session-local-only open-sse/utils/error.ts + error-sensitive-redaction open-sse/utils/publicCreds.ts + adobe-firefly src/shared/utils/circuitBreaker.ts + 8332-combo-vision-fallback None is a file this PR touches, and the gate reports the identical 11 on a worktree carrying none of these base-red fixes. Additions only (11 insertions, 0 deletions); the array stays sorted. This widens what the mutation run accounts for rather than relaxing anything. * chore(ci): re-measure accountFallback.ts file-size cap against the current base tip The entry frozen in this PR (1960) was the value at 75eb952; the base has since advanced to 1651617 and the file is 1966 there, so check:file-size would still have been red on the merge commit. Re-measured to 1966. Same inherited drift the note already documents: check:file-size does not run on the PR->release fast path, so growth accrues unmeasured between release rebaselines. The other four entries still match the current tip (tokenHealthCheck 841, chat 1866, auth 2486, combo frozen 3642 >= 3640). --------- Co-authored-by: backryun <busan011@ormbiz.co.kr>

fix(resilience,translator): three release/v3.8.49 base-red regression…

6139923

…s + eslint baseline — conflict resolved

herjarsa requested a review from diegosouzapw as a code owner July 24, 2026 21:44

backryun mentioned this pull request Jul 24, 2026

test(sse): repair two base-red gates on release/v3.8.49 #8490

Merged

backryun mentioned this pull request Jul 25, 2026

feat(dependencies): TypeScript 7 migration — tracking #8484

Closed

diegosouzapw added duplicate This issue or pull request already exists manual-review Aguardando revisão manual do dono (scope/contaminação) labels Jul 25, 2026

MumuTW mentioned this pull request Jul 25, 2026

chore(quality): ratchet file-size baseline to current code dimensions #8532

Closed

diegosouzapw closed this Jul 28, 2026

Navigation Menu

Uh oh!

fix(resilience,translator): three base-red regressions + eslint baseline — conflict resolved - #8482

fix(resilience,translator): three base-red regressions + eslint baseline — conflict resolved#8482
herjarsa wants to merge 1 commit into
diegosouzapw:release/v3.8.49from
herjarsa:fix/8254-basereds-rebased2

herjarsa commented Jul 24, 2026

Uh oh!

diegosouzapw commented Jul 25, 2026

Uh oh!

diegosouzapw commented Jul 25, 2026

Uh oh!

diegosouzapw commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

herjarsa commented Jul 24, 2026

Uh oh!

diegosouzapw commented Jul 25, 2026

Uh oh!

diegosouzapw commented Jul 25, 2026

Uh oh!

diegosouzapw commented Jul 28, 2026

Closing — all three base-red fixes already landed via #8254

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants