Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/check/check-error-helper.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ const IS_API_ROUTE = /^src\/app\/api\/.+\/route\.tsx?$/;
export const KNOWN_MISSING_ERROR_HELPER = new Set([
// --- original open-sse/executors + handlers scope (pre-6A.8) ---
// --- 6A.8 expanded scope: src/app/api/**/route.ts pre-existing violations ---
// TODO(6A.8): pre-existing, triage — route through buildErrorBody()/sanitizeErrorMessage()
// (empty — #8233 made open-sse/executors/muse-spark-web.ts import sanitizeErrorMessage,
// resolving the last frozen violator; see docs/security/ERROR_SANITIZATION.md)
]);

// Import specifiers that count as "uses the error helper" (path ends in utils/error).
Expand Down
1 change: 1 addition & 0 deletions tests/unit/sidebar-visibility.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ test("primary sidebar items place limits after cache", () => {
"context-ultra",
"context-omniglyph",
"compression-studio",
"compression-exclusions",
"cli-code",
"cli-agents",
"acp-agents",
Expand Down
13 changes: 11 additions & 2 deletions tests/unit/ui/sidebar-engine-items.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,20 @@ describe("COMPRESSION_CONTEXT_GROUP contains all 4 engine items", () => {
}
});

it("group order is Settings → Combos → engines → Studio", () => {
it("group order is Settings → Combos → engines → Studio → Exclusions", () => {
const ids = itemIds as string[];
assert.equal(ids[0], "context-settings", "Settings must be first");
assert.equal(ids[1], "context-combos", "Combos must be second");
assert.equal(ids[ids.length - 1], "compression-studio", "Studio must be last");
assert.equal(
ids[ids.length - 1],
"compression-exclusions",
"Exclusions must be last"
);
assert.equal(
ids[ids.length - 2],
"compression-studio",
"Studio must immediately precede Exclusions"
);
// Combos precedes every per-engine page.
const combosIdx = ids.indexOf("context-combos");
for (const id of ["context-caveman", "context-rtk", ...ENGINE_IDS]) {
Expand Down
Loading