fix(cpa): isolate credential-pool failures - #8308
Merged
diegosouzapw merged 2 commits intoJul 24, 2026
Merged
diegosouzapw merged 2 commits into
diegosouzapw merged 2 commits into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
RaviTharuma
force-pushed
the
fix/8280-cpa-credential-pool-isolation
branch
from
July 23, 2026 18:14
da920c7 to
8701022
Compare
Contributor
Author
|
Rebased the single focused commit onto current Fresh focused verification:
There is no owner review feedback and Git reports the PR mergeable. The broad failed jobs are the same baseline set present on merged #8292/#8296 (Docs Gates, Fast Quality Gates, Vitest, unit shards 1–4); their failures are unrelated to this five-file CPA provenance/key-health change, so no unrelated baseline fixes were added. |
The local recordKeyHealthStatus wrapper in handleChatCore only declared (status, creds), so the transport argument added for CPA credential-pool isolation was silently dropped at the call site (TS2554 "Expected 2 arguments, but got 3" once chatCore.ts is typechecked with tsc directly — this file is not in tsconfig.typecheck-core.json's file list, so `npm run typecheck:core` did not surface it). The CPA isolation guard in keyHealth.ts never received `transport`, so it never fired. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
Contributor
Author
|
Confirmed the owner follow-up commit
No unrelated baseline fixes were added. The refreshed CI run is still in progress. |
Owner
|
Merged into |
Merged
HouMinXi
pushed a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Aug 2, 2026
* fix(cpa): isolate credential pool failures Co-Authored-By: Claude <noreply@anthropic.com> * fix(cpa): forward transport through the chatCore key-health wrapper The local recordKeyHealthStatus wrapper in handleChatCore only declared (status, creds), so the transport argument added for CPA credential-pool isolation was silently dropped at the call site (TS2554 "Expected 2 arguments, but got 3" once chatCore.ts is typechecked with tsc directly — this file is not in tsconfig.typecheck-core.json's file list, so `npm run typecheck:core` did not surface it). The CPA isolation guard in keyHealth.ts never received `transport`, so it never fired. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
* fix(cpa): isolate credential pool failures Co-Authored-By: Claude <noreply@anthropic.com> * fix(cpa): forward transport through the chatCore key-health wrapper The local recordKeyHealthStatus wrapper in handleChatCore only declared (status, creds), so the transport argument added for CPA credential-pool isolation was silently dropped at the call site (TS2554 "Expected 2 arguments, but got 3" once chatCore.ts is typechecked with tsc directly — this file is not in tsconfig.typecheck-core.json's file list, so `npm run typecheck:core` did not surface it). The CPA isolation guard in keyHealth.ts never received `transport`, so it never fired. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
node --import tsx/esm --test tests/unit/chatcore-key-health.test.ts— 6 passednpm run typecheck:core— passedgit diff --check— passedThe broad CI failure set matches the repository baseline on merged PRs #8292 and #8296: Docs Gates, Fast Quality Gates, Vitest, and all four unit shards fail independently of this five-file CPA diff. No unrelated baseline files were modified.
This is the focused CPA credential-pool isolation follow-up; the Kimi non-stream half is handled separately in #8302.
Refs #8280