Repository navigation
fix(cli): resolve claude.cmd on Windows in omniroute launch (#8246) - #8283
Merged
diegosouzapw merged 1 commit intoJul 23, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
spawn('claude') without shell:true cannot resolve the .cmd shim
that npm installs on Windows, causing ENOENT and a misleading
'not found in PATH' error. Use claude.cmd + shell:true + windowsHide
on win32, matching the pattern already used in launch-codex.mjs.
Owner
|
Thanks, @Dingding-leo! 🙏 Merged — resolves claude.cmd on Windows in the omniroute launcher. Validated on the merge-train. |
Merged
HouMinXi
pushed a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Aug 2, 2026
…zapw#8246) (diegosouzapw#8283) spawn('claude') without shell:true cannot resolve the .cmd shim that npm installs on Windows, causing ENOENT and a misleading 'not found in PATH' error. Use claude.cmd + shell:true + windowsHide on win32, matching the pattern already used in launch-codex.mjs. Co-authored-by: Austin Liu <austinliu@Austins-MacBook-Air-3.local>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…zapw#8246) (diegosouzapw#8283) spawn('claude') without shell:true cannot resolve the .cmd shim that npm installs on Windows, causing ENOENT and a misleading 'not found in PATH' error. Use claude.cmd + shell:true + windowsHide on win32, matching the pattern already used in launch-codex.mjs. Co-authored-by: Austin Liu <austinliu@Austins-MacBook-Air-3.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8246.
omniroute launchfails on Windows with "The 'claude' CLI was not found in PATH" even thoughclaude.cmdis on PATH.Root Cause
spawn('claude', ...)withoutshell: truecannot resolve the.cmdshim that npm installs on Windows (PATHEXT resolution requires a shell). Node reports ENOENT, the code prints a misleading "not found" message, then crashes with a libuv assertion.launch-codex.mjsalready handles this correctly viaresolveCodexSpawn()—launch.mjswas missed.Changes
bin/cli/commands/launch.mjs: On win32, spawnclaude.cmdwithshell: true+windowsHide: true, matching the pattern inlaunch-codex.mjs. Non-Windows behavior unchanged.Verification
node --check bin/cli/commands/launch.mjs— syntax OK1 file changed, +8 −1