fix(dashboard): keep Compression Studio last after exclusions page (base-red slice 5) - #8259
Closed
diegosouzapw wants to merge 1 commit into
Closed
diegosouzapw wants to merge 1 commit into
diegosouzapw wants to merge 1 commit into
Conversation
…e was added Base-red slice 5. #8034/#8064 (per-model/endpoint compression exclusion filter) appended the new `compression-exclusions` sidebar item to the END of the compression group, after `compression-studio`. That broke the deliberate "Compression Studio is the last item of the compression group" invariant asserted by two tests (sidebar-engine-items "Studio must be last" and sidebar-visibility's exact-order array, whose expected list places compression-studio immediately before cli-code). Rather than weaken the invariant, moved `compression-exclusions` ABOVE `compression-studio` in sections.ts (new pages go above the Studio showcase) and added the new item to sidebar-visibility's expected order. Both tests, plus the other four sidebar suites (reorg / back-compat / tools / engine-items), stay green.
12 tasks done
Owner
Author
|
Closing as superseded — the sidebar-visibility + sidebar-engine-items tests this slice targeted already pass on the current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cluster: sidebar exclusions ordering (base-red slice 5)
Quinto slice (após #8254, #8256, #8257, #8258). #8034/#8064 (per-model/endpoint compression exclusion filter) apendou
compression-exclusionsno fim do grupo de compressão, depois decompression-studio, quebrando o invariante deliberado "Compression Studio é o último item do grupo" (2 testes:sidebar-engine-items"Studio must be last" e o array de ordem exata desidebar-visibility).Fix
Em vez de enfraquecer o invariante, movi
compression-exclusionspara antes decompression-studioemsections.ts(páginas novas ficam acima da vitrine Studio) e inseri o item no array esperado desidebar-visibility.Validação
Todos os 5 suites de sidebar verdes:
sidebar-engine-items14/0,sidebar-visibility7/0,sidebar-monitoring-reorg7/0,sidebar-back-compat6/0,sidebar-tools-group5/0.