fix(#8093): align INPUT_SANITIZER_ENABLED default to true across all docs - #8185
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Thanks for tracking down the docs/runtime mismatch — verified: One thing I want to flag before this merges: the branch carries 8 commits, but only the last one ( To keep things clean I'll cherry-pick just the #8093 commit onto the current tip and merge that in isolation — no action needed from you unless you'd rather rebase this branch down to a single commit yourself. Nothing else to change on the docs fix itself — nice catch. |
e06f2a1 to
7441966
Compare
c680293 to
3bdf35c
Compare
Code defaults INPUT_SANITIZER_ENABLED to enabled (any value that is not exactly 'false'). Updated .env.example and 41 i18n translations of ENVIRONMENT.md to match this default instead of showing false. Fixes diegosouzapw#8093
3bdf35c to
00e3e3f
Compare
# Conflicts: # .env.example # README.md
|
Thanks, @rafaumeu! 🙏 Merged — aligns the INPUT_SANITIZER_ENABLED docs to the on-by-default reality across the English ENVIRONMENT.md, all 41 i18n translations, and .env.example (now shows =false as the disable toggle), plus a regression guard test. This complements #8113/#8124 (which covered the English docs) by propagating the correction to every locale. Rebased onto the current release tip. typecheck + i18n key-coverage + glossary gates green. |
7c07c9d
into
diegosouzapw:release/v3.8.49
… across all docs (diegosouzapw#8185) * fix(ci): resolve upstream-inherited check failures * fix(docs): align INPUT_SANITIZER_ENABLED default to true across all docs Code defaults INPUT_SANITIZER_ENABLED to enabled (any value that is not exactly 'false'). Updated .env.example and 41 i18n translations of ENVIRONMENT.md to match this default instead of showing false. Fixes diegosouzapw#8093 --------- Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
… across all docs (diegosouzapw#8185) * fix(ci): resolve upstream-inherited check failures * fix(docs): align INPUT_SANITIZER_ENABLED default to true across all docs Code defaults INPUT_SANITIZER_ENABLED to enabled (any value that is not exactly 'false'). Updated .env.example and 41 i18n translations of ENVIRONMENT.md to match this default instead of showing false. Fixes diegosouzapw#8093 --------- Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
Summary
The runtime default for
INPUT_SANITIZER_ENABLEDis enabled (any value that is not exactly"false"), but docs and.env.exampleincorrectly presented it as opt-in (defaultfalse).Changes
.env.example: changed commented example from# INPUT_SANITIZER_ENABLED=trueto# INPUT_SANITIZER_ENABLED=falsewith note "Enabled by default. Set to "false" to disable."ENVIRONMENT.mdupdated from\false`to`true``tests/unit/env-docs-input-sanitizer-8093.test.ts: consistency tests verifying code/docs/env.example alignmentFixes #8093