Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixes/sec-adm-zip-codeql-host-match.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- fix(security): bump adm-zip to ^0.6.0 (dev transitive via promptfoo/onnxruntime-node) to clear the crafted-ZIP 4GB-allocation advisory, and tighten mitm DNS test host assertions to exact/suffix matching (CodeQL js/incomplete-url-substring-sanitization)
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@
},
"node-gyp": {
"undici": "^6.27.0"
}
},
"adm-zip": "^0.6.0"
}
}
6 changes: 3 additions & 3 deletions tests/unit/mitm-dns-graceful-degrade-6127.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ test("provisionDnsEntries: a failing agent/custom step does not stop the others
},
addHostsDns: async (hosts: string[]) => {
// Custom-hosts call must still happen even after default + agent errors.
if (hosts.includes("custom.example.com")) customCalled = true;
if (hosts.some((h) => h === "custom.example.com")) customCalled = true;
},
getAgentStates: () => [{ dns_enabled: true, agent_id: "__nonexistent_agent__" }] as never,
listEnabledCustomHosts: () => [{ host: "custom.example.com" }] as never,
Expand Down Expand Up @@ -205,8 +205,8 @@ test("provisionDnsEntries: canElevate() returning true proceeds with DNS provisi
},
addHostsDns: async (hosts: string[], sudoPassword: string) => {
capturedPasswords.push(sudoPassword);
if (hosts.some((h) => h.includes("googleapis.com"))) agentCalled = true;
if (hosts.includes("custom.example.com")) customCalled = true;
if (hosts.some((h) => h.endsWith(".googleapis.com"))) agentCalled = true;
if (hosts.some((h) => h === "custom.example.com")) customCalled = true;
},
canElevate: () => true,
getAgentStates: () => [{ dns_enabled: true, agent_id: "antigravity" }] as never,
Expand Down
Loading