Repository navigation
test(providers): fix release base-reds from today's provider merges - #7639
diegosouzapw wants to merge 1 commit into
Conversation
Two unit tests were born red on release/v3.8.49 after today's provider additions, blocking every open release PR on Unit Tests fast-path (3/4): 1. model-connid-prefix-normalization-6772.test.ts used PREFIX="fta" as a placeholder custom-node prefix. #7602 (FreeTheAi) registered alias:"fta" (gateways.ts / freetheai/index.ts), so the resolver now routes fta/... to the real provider before the custom-node lookup. Repoint the placeholder to the collision-free "zzq6772" — production behaviour (a registered alias wins) is correct; the fixture just picked an unlucky token. 2. provider-translate-path-golden.test.ts snapshots every registered provider. #7602 added freetheai to the chat registry (189 -> 190 providers). Regenerated via UPDATE_GOLDEN=1. Audited the diff: exactly one key added (freetheai, format=openai, valid chat URL), zero existing providers changed, zero removed — a legitimate snapshot update, not a masked regression. Both tests pass locally. No production code touched.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Obrigado por abrir isso — mas esse mesmo fix (PREFIX "fta"→placeholder collision-free + regen do golden snapshot com "freetheai") já foi aplicado direto na release em |
|
Fechando como subsumida: os base-reds de provider da release já foram limpos diretamente no tip via commit |
1 participant
Problem
Two unit tests were born red on
release/v3.8.49after today's provider-addition merges, so every open release PR failsUnit Tests fast-path (3/4)through no fault of its own (confirmed on #7628, #7314, and the #6917 cluster). This is a base regression, not a per-PR defect.Root cause & fix
1.
model-connid-prefix-normalization-6772.test.tsusedPREFIX = "fta"as a placeholder custom-node prefix. #7602 (FreeTheAi) registeredalias: "fta"(gateways.ts:243,freetheai/index.ts:9), so the resolver now routesfta/...to the real provider before the custom-node lookup → the test's assumption breaks.→ Repoint the placeholder to the collision-free
"zzq6772". Production behaviour (a registered alias wins) is correct; the fixture just picked a token that later became real. Not a masked assertion — the test still proves prefix-stripping for a custom node.2.
provider-translate-path-golden.test.tssnapshots every registered provider. #7602 addedfreetheaito the chat registry (189 → 190) → snapshot stale.→ Regenerated via
UPDATE_GOLDEN=1. Audited the diff (verify-not-mask): exactly one key added (freetheai,format=openai, validhttps://api.freetheai.xyz/v1/chat/completions), zero existing providers changed, zero removed. Legitimate snapshot update.Validation (Hard Rule #18)
model-connid-prefix-normalization-6772.test.ts→ 3 pass, 0 failprovider-translate-path-golden.test.ts(noUPDATE_GOLDEN) → 3 pass, 0 failNo production code touched — test/snapshot only. Unblocks
Unit Tests fast-path (3/4)for all release PRs.(The remaining
Fast Quality Gates → check:mutation-test-coverageanddast-smokereds are separate base-reds, not addressed here.)