Skip to content

docs(routing): reconcile 17 vs 18 public-strategy count in AUTO-COMBO - #6646

Merged
diegosouzapw merged 6 commits into
diegosouzapw:release/v3.8.47from
chirag127:docs/auto-combo-reconcile-17-vs-18-strategy-count
Jul 9, 2026
Merged

diegosouzapw merged 6 commits into
diegosouzapw:release/v3.8.47from
chirag127:docs/auto-combo-reconcile-17-vs-18-strategy-count

Conversation

@chirag127

Copy link
Copy Markdown
Contributor

Problem

docs/routing/AUTO-COMBO.md contradicts itself 5 lines apart in the Testing & Coverage section:

  • Line 605: "proves the routing decision of all 17 public strategies end-to-end"
  • Line 610: "All 18 ROUTING_STRATEGY_VALUES strategies"

The constants file (src/shared/constants/routingStrategies.ts:1-20) declares 18 public values — so 18 is correct. The stale "17" predates the pipeline strategy addition (#6396), which is already called out at line 198 of the same doc.

Line 177 of the same doc also already states "18 routing strategies", so line 605 is the single remaining inconsistency.

Fix

One-word edit on docs/routing/AUTO-COMBO.md:605:

-`tests/integration/combo-matrix/*.test.ts` proves the routing **decision** of all 17
+`tests/integration/combo-matrix/*.test.ts` proves the routing **decision** of all 18
 public strategies end-to-end through the real combo pipeline with a mocked upstream.

Testing

Docs-only change (no src/, open-sse/, electron/, bin/ touched), so hard rule #8 and #18 don't require a test. Manual verification:

grep -nE "all (17|18) .*public strategies" docs/routing/AUTO-COMBO.md
# expect a single hit on line 605 saying "18"
grep -c '".*"' src/shared/constants/routingStrategies.ts | head
# ROUTING_STRATEGY_VALUES length = 18

Alternatives considered

  • Change line 610 down to 17 — rejected: contradicts the constants file (source of truth) and line 177.
  • Rewrite both lines for clarity — rejected: current wording is fine, only the number is wrong.

Thanks for the excellent OmniRoute!

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants