feat(ci): check:test-masking flags inline-reimplemented prod conditions (#6348) #6393
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,10 @@ import { | |
| evaluateMasking, | ||
| evaluateDeletedFiles, | ||
| partitionDeletedRenamed, | ||
| countSignificantTokens, | ||
| extractProdConditions, | ||
| extractImports, | ||
| findReimplementedConditions, | ||
| } from "../../scripts/check/check-test-masking.mjs"; | ||
|
|
||
| // ─── Existing tests (must stay green) ──────────────────────────────────────── | ||
|
|
@@ -409,3 +413,130 @@ test("evaluateMasking: allowlist exempts ONLY reduction — tautology/skip still | |
| assert.ok(r.some((f) => /tautolog/i.test(f))); | ||
| assert.ok(r.some((f) => /skip/i.test(f))); | ||
| }); | ||
|
|
||
| // ─── 6348 Subcheck 4: inline-reimplemented prod conditions (REPORT-ONLY) ────── | ||
|
|
||
| test("countSignificantTokens: `status >= 500` has 3 significant tokens", () => { | ||
| assert.equal(countSignificantTokens("status >= 500"), 3); | ||
| }); | ||
|
|
||
| test("countSignificantTokens: `x === LIMIT && y` has 3 significant tokens", () => { | ||
| assert.equal(countSignificantTokens("x === LIMIT && y"), 3); | ||
| }); | ||
|
|
||
| test("countSignificantTokens: trivial `x > 0` has <3 significant tokens (noise guard)", () => { | ||
| assert.ok(countSignificantTokens("x > 0") < 3); | ||
| }); | ||
|
|
||
| test("extractProdConditions: pulls the if-condition and its owning symbol", () => { | ||
| const prod = [ | ||
| "export function isServerError(status) {", | ||
| " if (status >= 500) {", | ||
| " return true;", | ||
| " }", | ||
| " return false;", | ||
| "}", | ||
| ].join("\n"); | ||
| const conds = extractProdConditions(prod); | ||
| const hit = conds.find((c) => c.condition === "status >= 500"); | ||
| assert.ok(hit, "the ≥3-token condition is extracted"); | ||
| assert.equal(hit.owner, "isServerError"); | ||
| }); | ||
|
|
||
| test("extractProdConditions: ignores trivial <3-token conditions", () => { | ||
| const prod = "export function f(x) {\n if (x > 0) return 1;\n return 0;\n}"; | ||
| assert.deepEqual(extractProdConditions(prod), []); | ||
| }); | ||
|
|
||
| test("extractImports: collects named bindings and module specifiers", () => { | ||
| const src = `import { isServerError, foo } from "../src/http";\nimport def from "./bar";`; | ||
| const names = extractImports(src); | ||
| assert.ok(names.has("isServerError")); | ||
| assert.ok(names.has("foo")); | ||
| assert.ok(names.has("def")); | ||
| }); | ||
|
|
||
| const PROD_SERVER_ERROR = [ | ||
| "export function isServerError(status) {", | ||
| " if (status >= 500) {", | ||
| " return true;", | ||
| " }", | ||
| " return false;", | ||
| "}", | ||
| ].join("\n"); | ||
|
|
||
| test("MASKED: test re-implements `status >= 500` without importing the owner → flagged", () => { | ||
| const testSrc = [ | ||
| 'import { test } from "node:test";', | ||
| 'import assert from "node:assert";', | ||
| "// re-encodes the prod branch locally instead of importing isServerError", | ||
| "function localCheck(status) {", | ||
| " return status >= 500;", | ||
| "}", | ||
| 'test("server error", () => {', | ||
| " assert.equal(localCheck(503), true);", | ||
| "});", | ||
| ].join("\n"); | ||
| const flags = findReimplementedConditions( | ||
| [PROD_SERVER_ERROR], | ||
| testSrc, | ||
| extractImports(testSrc) | ||
| ); | ||
| assert.equal(flags.length, 1); | ||
| assert.equal(flags[0].condition, "status >= 500"); | ||
| assert.equal(flags[0].owner, "isServerError"); | ||
| }); | ||
|
|
||
| test("CLEAN: test imports and calls the real function → not flagged", () => { | ||
| const testSrc = [ | ||
| 'import { test } from "node:test";', | ||
| 'import assert from "node:assert";', | ||
| 'import { isServerError } from "../../src/http";', | ||
| 'test("server error", () => {', | ||
| " assert.equal(isServerError(503), true);", | ||
| " assert.equal(isServerError(200), false);", | ||
| "});", | ||
| ].join("\n"); | ||
| const flags = findReimplementedConditions( | ||
| [PROD_SERVER_ERROR], | ||
| testSrc, | ||
| extractImports(testSrc) | ||
| ); | ||
| assert.deepEqual(flags, []); | ||
| }); | ||
|
|
||
| test("CLEAN: importing the owner exempts even a textual copy of its condition", () => { | ||
| // The test both imports the owner AND happens to spell the condition — importing | ||
| // the owner means it exercises the real symbol, so the condition is not masked. | ||
| const testSrc = [ | ||
| 'import { isServerError } from "../../src/http";', | ||
| "// documents that isServerError fires when status >= 500", | ||
| 'test("t", () => { isServerError(503); });', | ||
| ].join("\n"); | ||
| const flags = findReimplementedConditions( | ||
| [PROD_SERVER_ERROR], | ||
| testSrc, | ||
| extractImports(testSrc) | ||
| ); | ||
| assert.deepEqual(flags, []); | ||
| }); | ||
|
|
||
| test("CLEAN: trivial `x > 0` condition is never flagged (noise guard)", () => { | ||
| const prod = "export function f(x) {\n if (x > 0) return 1;\n return 0;\n}"; | ||
| const testSrc = [ | ||
| 'import { test } from "node:test";', | ||
| "function local(x) { return x > 0; }", | ||
| 'test("t", () => { local(1); });', | ||
| ].join("\n"); | ||
| const flags = findReimplementedConditions([prod], testSrc, extractImports(testSrc)); | ||
| assert.deepEqual(flags, []); | ||
| }); | ||
|
|
||
| test("findReimplementedConditions: matches despite operator-spacing differences", () => { | ||
| const prod = "export function big(status) {\n if (status >= 500) return true;\n}"; | ||
| // test spells the same condition with no spaces around the operator | ||
| const testSrc = "function local(status){ return status>=500; }"; | ||
| const flags = findReimplementedConditions([prod], testSrc, extractImports(testSrc)); | ||
| assert.equal(flags.length, 1); | ||
| assert.equal(flags[0].condition, "status >= 500"); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In TypeScript, variable declarations often have type annotations (e.g.,
const isServerError: Handler = ...) and classes are frequently used. The currentdeclRefails to capture variable names with type annotations because of the strict\s*=check, and it completely ignores class declarations. This leads to false positives where conditions are flagged as reimplemented even when their owning symbols or classes are imported.We can make the type annotation optional in the regex and add support for class declarations to ensure they are correctly resolved as owners.