Skip to content

test(dashboard): realign #6145 onboarding-href guard to #6166 helper refactor #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 1 commit into from
Jul 5, 2026
Merged

test(dashboard): realign #6145 onboarding-href guard to #6166 helper refactor #6270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions tests/unit/onboarding-wizard-details-link-6145.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ import { dirname, join } from "node:path";
// `/dashboard/providers/[id]` route expects), NOT `connection.provider` (the
// provider slug/type). The old code produced `/dashboard/providers/<provider-slug>`
// which 404s for openai-compatible / anthropic-compatible providers.
//
// #6166 refactored the inline `href={`/dashboard/providers/${connection.id}`}`
// literal into the tested `buildProviderDetailsHref(connection)` helper (its
// id-based routing + null-safety is guarded behaviorally in
// `provider-onboarding-href.test.ts`). This guard now tracks that refactor: the
// wizard must delegate to the helper and must NOT reintroduce a raw
// `connection.provider` URL.

const here = dirname(fileURLToPath(import.meta.url));
const repoRoot = join(here, "..", "..");
Expand All @@ -20,11 +27,11 @@ const wizard = readFileSync(
"utf8"
);

test("#6145: provider-details link routes by connection.id (matches the [id] route)", () => {
test("#6145: provider-details link routes through buildProviderDetailsHref (id-based helper)", () => {
assert.match(
wizard,
/href=\{`\/dashboard\/providers\/\$\{connection\.id\}`\}/,
"the details link must build the URL from connection.id"
/buildProviderDetailsHref\(connection\)/,
"the details link must be built by the tested buildProviderDetailsHref helper (routes by connection.id)"
);
});

Expand Down
Loading