feat(opencode): Proxy Pool dropdown (by-id) for account proxies (#5217 Gap 1) - #5370
Merged
Merged
Conversation
… proxies (#5217 Gap 1) Replaces the always-manual per-account proxy modal with a Saved/Custom toggle. 'Saved' picks a pool proxy from GET /api/settings/proxies and stores {fingerprint, proxyId} (by-id reference — editing the pool proxy propagates to all accounts using it); 'Custom' keeps the manual inputs (stored inline) as an escape hatch. Server-side resolveAccountProxiesFromRegistry resolves proxyId -> record so the executor receives a resolved proxy unchanged; inline entries keep working; unknown/deleted proxyId degrades to direct (no crash). Regression guards: noauth-proxy-resolution.test.ts, ui/noauth-account-card.test.tsx.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
… proxies (diegosouzapw#5217 Gap 1) (diegosouzapw#5370) Integrated into release/v3.8.41 — Proxy Pool dropdown by-id for account proxies (diegosouzapw#5217 Gap 1).
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
Restores opencode-proxy-pool (diegosouzapw#5370) + thinking RC-C (diegosouzapw#5367) bullets and adds the thinking A/B/D (diegosouzapw#5352) bullet, all under a single header. Additive restore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Gap 1 of #5217 (follow-up to the Stage 1 logging/observability PR #5351).
What
The OpenCode Free per-account proxy modal no longer forces manual Host/Port/credentials on every card. A Saved / Custom toggle:
GET /api/settings/proxies); stored as a by-id reference{fingerprint, proxyId}, so editing that pool proxy propagates to every account using it (the reporter's exact ask).Server-side
resolveAccountProxiesFromRegistry(newsrc/sse/services/noAuthProxyResolution.ts) resolvesproxyId → recordin the no-auth credential path, so the executor receives a resolved proxy unchanged. Backward-compatible: existing inline entries keep working; an unknown/deletedproxyIddegrades safely to direct (no crash). Persistence uses the lighter hydrate-by-id model (noproxy_assignmentsmigration).Validation (Hard Rule #18)
noauth-proxy-resolution.test.ts(9): by-id resolve, credential omission, inline passthrough, unknown/deleted id, throwing lookup, precedence, malformed input. Fully unit-covered.ui/noauth-account-card.test.tsx(+3): defaults to dropdown, persists{fingerprint, proxyId}on save, shield lights from a resolved reference.