fix(sse): replace synthesized kiro "Continue" turn with neutral filler (#5231) - #5303
Merged
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
#5231) When an OpenAI->Kiro request ends on an assistant/tool turn, convertMessages synthesizes the protocol-required trailing user turn. The literal word "Continue" could be read by Kiro/CodeWhisperer as a real user instruction and trigger unintended agent action. Use a neutral filler ("...") instead. A trailing tool-result turn is still promoted as-is (it already collapses to a real user turn); only the assistant-text-ending case is affected. Regression guards: tests/unit/kiro-continue-filler-5231.test.ts.
diegosouzapw
force-pushed
the
fix/5231-kiro-continue-filler
branch
from
June 29, 2026 06:48
7281027 to
25ec2f1
Compare
2 tasks
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
diegosouzapw#5231) (diegosouzapw#5303) Integrated into release/v3.8.40 (CHANGELOG re-resolved against post-diegosouzapw#5294/diegosouzapw#5304 tip; kiro code identical to the green commit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5231
Problem
open-sse/translator/request/openai-to-kiro.ts(convertMessages) requirescurrentMessageto be a user turn. When an OpenAI→Kiro request ends on an assistant/tool turn (no trailing user turn to promote), the translator synthesizes one with literal content"Continue". Kiro/CodeWhisperer can read the word"Continue"as a real user instruction and take unintended agent action.Fix
Replace the synthesized filler
"Continue"→"..."(neutral). Single-string behavioral change at the synthesized trailing-turn site (openai-to-kiro.ts:415).Scope (intentionally narrow)
toolResults), so it never hits the synthesized-filler branch. Only the assistant-text-ending case changes.TDD / Validation (Hard Rule #18)
tests/unit/translator-openai-to-kiro.test.ts(Continue → neutral filler) — failed on the unfixed code, passes after the fix.tests/unit/kiro-continue-filler-5231.test.ts:"Continue"filler;node --test(kiro suites): 31/31 pass.typecheck:coreclean,eslint0 errors,check:file-sizeclean (source kept net-neutral under the frozen cap; new tests in a fresh file),check:test-discoveryOK.