test(targets): add 14 unit tests for targetExhaustion handler - #5296
Merged
diegosouzapw merged 4 commits intoJun 29, 2026
Merged
diegosouzapw merged 4 commits into
diegosouzapw merged 4 commits into
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
…havior The 3 quota-path cases asserted a mental model that diverged from applyComboTargetExhaustion's real semantics, so they failed against the release code: - isProviderExhaustedReason reads reason/creditsExhausted/dailyQuotaExhausted, not error.code → signal exhaustion via creditsExhausted/reason. - classifyErrorText flags 'quota exceeded' (not 'exhausted your quota') as QUOTA_EXHAUSTED → use a matched phrase. - openai is NOT a per-model-quota provider; gemini is → use gemini for the per-model-quota (advance, don't exhaust) case. Each test keeps its original intent; only the inputs/provider are corrected to exercise the real code path. 13/13 green. Co-authored-by: diegosouzapw <diegosouza.pw@gmail.com>
…runner The new open-sse/services/combo/__tests__/targetExhaustion.test.ts matched vitest.config.ts's include glob but NOT vitest.mcp.config.ts (the config that test:vitest actually runs in CI), so check:test-discovery flagged it as an orphan that no runner collects. Register the combo/__tests__ glob in vitest.mcp.config.ts and mirror it in the check-test-discovery COLLECTORS so the suite runs in the blocking test-vitest job. 13/13 green; discovery OK. Co-authored-by: diegosouzapw <diegosouza.pw@gmail.com>
# Conflicts: # scripts/check/check-test-discovery.mjs # vitest.mcp.config.ts
diegosouzapw
added a commit
that referenced
this pull request
Jun 29, 2026
Merged
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…ouzapw#5296) Integrated into release/v3.8.40
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…rgetExhaustion tests (diegosouzapw#5296)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 14 unit tests for the targetExhaustion handler covering: