fix(compression): propagate hard-budget unreachable-target warning through the stacked seam (follow-up #5288) - #5291
Merged
diegosouzapw merged 1 commit intoJun 29, 2026
Conversation
…rough the stacked seam The seam gated the validationWarnings merge on hbResult.compressed, so when every unit is preserve-guarded (nothing dropped, compressed=false) the #17 'warn instead of fail silently' guarantee was lost through applyStackedCompression. Merge the warnings on the else branch in both the sync and async stacked paths + add a propagation regression test.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…rough the stacked seam (diegosouzapw#5291) Follow-up to diegosouzapw#5288: propagate the hard-budget unreachable-target warning through the stacked seam (else branch in both sync/async paths) + TDD propagation test. Integrated into release/v3.8.40.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5288 (roadmap #17 hard-budget). The deep review of #5288 found one low-severity gap that shipped: the unreachable-budget
validationWarningsis dropped through the stacked-pipeline seam.applyStackedCompression/...Asyncgate the warning merge onif (hbResult.compressed). When every unit is preserve-guarded, hard-budget drops nothing →compressed === false→ thevalidationWarnings(the "could not reach target" diagnostic, #5288's own fix #3) are never merged into the accumulator. So through the production stacked path the warning is silently swallowed; it only surfaced when callers invokedapplyHardBudgetdirectly.Fix
Merge the warnings on the
elsebranch in both the sync and async stacked seams (strategySelector.ts), so the advisory surfaces even when no unit could be dropped.Validation (TDD)
Added a regression test that drives an all-preserve-guarded body through
applyStackedCompressionand asserts the warning propagates (fails without the fix, passes with it).hard-budget.test.ts19/19, typecheck clean, file-size OK.Low severity — advisory diagnostic only, fail-open intact, body passes through unchanged either way; this just restores the stated "warn instead of fail silently" guarantee in the production path.