fix(dashboard): GitHub releases fallback for Update Available banner (#4100) - #5266
Merged
diegosouzapw merged 1 commit intoJun 28, 2026
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4100 (re-opened after the v3.8.28 fix).
Why still broken
The v3.8.28 fix added an npm-registry HTTP fallback to
resolveLatestVersion(). But on networks that reach GitHub (where the dashboard news feed already loads viagetNews()) yet blockregistry.npmjs.org+ have nonpmbinary (Docker/desktop/locked-down), both existing sources still return null →updateAvailable=false→ banner silently hidden. This is the surviving cause reported by @csoxiza.Verified from a clean internet host: npm CLI,
registry.npmjs.org/omniroute/latestandapi.github.com/.../releases/latestall return3.8.39— so the logic is correct when a source is reachable; the gap is source reachability.Fix
resolveLatestVersion()now tries npm CLI → npm registry → GitHub releases before giving up (the GitHub source the issue itself suggested), and warns only when all three fail. NewgetLatestVersionFromGitHub()reads the latest releasetag_name(v-prefix tolerated bynormalizeVersion).Tests
tests/unit/system-version-check-4100.test.ts(12/12): GitHub fallback engaged only after npm CLI + registry fail; registry short-circuits before GitHub;tag_nameparsing; non-OK → null; all-fail → null. Fail-before: the GitHub export/param did not exist on the prior module.