fix(db): registrar caseMapping/schemaColumns como db-internal (check-db-rules) - #4966
Closed
diegosouzapw wants to merge 115 commits into
Closed
diegosouzapw wants to merge 115 commits into
diegosouzapw wants to merge 115 commits into
Conversation
…ease-acceleration) (#4857) * feat(quality): add check:test-runner-api gate (vitest-only dirs must use vitest API) * feat(release): reusable CHANGELOG i18n-mirror sync script * chore(ops): add prune-stale-worktrees.sh (dry-run by default) * ci(quality): run test-runner-api + docs-all + vitest + full unit suite on PR->release fast-path --------- Co-authored-by: Diego Rodrigues de Sa e Souza <souzamiriamrodrigues790@gmail.com>
…rough (port from 9router#1157) (#4624) Integrated into release/v3.8.36 — port (rebuilt from stale base; defining commit cherry-picked clean over release tip, release-green validated)
…rmat providers (#4625) Integrated into release/v3.8.36 — port (rebuilt from stale base; defining commit cherry-picked clean over release tip, release-green validated)
…ocks (#4633) Integrated into release/v3.8.36 — port (rebuilt from stale base; defining commit cherry-picked clean over release tip, release-green validated)
…thropic providers (#4650) Integrated into release/v3.8.36 — port (rebuilt from stale base; defining commit cherry-picked clean over release tip, release-green validated)
…4651) Integrated into release/v3.8.36 — port (rebuilt from stale base; defining commit cherry-picked clean over release tip, release-green validated)
Integrated into release/v3.8.36 — port (rebuilt from stale base; defining commit cherry-picked clean over release tip, release-green validated)
…4656) Integrated into release/v3.8.36 — port (rebuilt from stale base; defining commit cherry-picked clean over release tip, release-green validated)
…ttings (#4659) Integrated into release/v3.8.36 — port (rebuilt from stale base; defining commit cherry-picked clean over release tip, release-green validated)
) (#4629) Integrated into release/v3.8.36 — kiro region SSRF guard (GHSA-6mwv-4mrm-5p3m), port rebuilt clean over release tip
…sages (#4657) Integrated into release/v3.8.36 — anthropic-compat validation via POST /v1/messages (port 584cf66a), rebuilt clean + baseline; release-green
…#4658) Integrated into release/v3.8.36 — port rebuilt clean over release tip, release-green validated
Integrated into release/v3.8.36
Integrated into release/v3.8.36
Integrated into release/v3.8.36
…usage.ts (#4950) Integrated into release/v3.8.36
Integrated into release/v3.8.36
…4735) Integrated into release/v3.8.36
…4860) Integrated into release/v3.8.36
…4905) Integrated into release/v3.8.36
…4946) Integrated into release/v3.8.36
Integrated into release/v3.8.36
Integrated into release/v3.8.36
Integrated into release/v3.8.36
Integrated into release/v3.8.36
…ay-name (#4961) Integrated into release/v3.8.36
…k-db-rules O godfile-split de db/core.ts (#4947) extraiu dois leaves db-internal — caseMapping (snake↔camel column mapping puro) e schemaColumns (reconciliação idempotente de colunas) — ambos importados SÓ por db/core.ts. O gate check:db-rules (#2 re-export) exige que todo módulo db/ novo seja re-exportado por localDb.ts OU justificado em INTENTIONALLY_INTERNAL. Como são plumbing interno (não CRUD de domínio), re-exportar via localDb incentivaria o anti-padrão de barrel-import proibido pela Rule #2 — então entram na allowlist com classificação db-internal, igual a healthCheck/migrationRunner/optimizationSettings. Sem isso o release PR (release/v3.8.36 → main) vermelha no primeiro CI. Atualiza o teste de contagem auditada (30 → 32).
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
Fechando como obsoleto: o gate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O godfile-split de
db/core.ts(#4947) extraiu dois leaves db-internal que ficaram sem registro no gatecheck:db-rules:src/lib/db/caseMapping.ts— snake↔camel column mapping purosrc/lib/db/schemaColumns.ts— reconciliação idempotente de colunas (ALTER TABLE … ADD COLUMN+ introspecção)Ambos são importados só por
db/core.ts(grepconfirma um único importer cada). A regra #2 (re-export) do checker exige que todo módulodb/novo seja re-exportado porlocalDb.tsou justificado emINTENTIONALLY_INTERNAL. Como são plumbing interno (não CRUD de domínio), re-exportá-los vialocalDbincentivaria o anti-padrão de barrel-import proibido pela Hard Rule #2 — então entram na allowlist com classificaçãodb-internal, exatamente comohealthCheck/migrationRunner/optimizationSettings.Por que importa
Pré-flight
npm run check:release-greenna HEAD dorelease/v3.8.36acusou este HARD failure. Sem o fix, o release PR #4854 (release/v3.8.36 → main) vermelharia no primeiro CI (jobdb-rules).Validação (Rule #18 — gate red→green)
[#2 re-export] 2 módulo(s) db/ não re-exportado(s): caseMapping, schemaColumns→ exit 1[check-db-rules] OK (91 módulos db/, 59 re-exportados, 32 intencionalmente-internos)tests/unit/check-db-rules{,-classification}.test.ts: 27/27 pass (contagem auditada 30→32; ambos passam o teste de "≥1 importer real")Só
scripts/+ teste do gate — zero código de produção tocado.