-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
fix(translator): strip top-level client_metadata on the OpenAI passthrough #4624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
diegosouzapw
merged 1 commit into
release/v3.8.36
from
fix/port-issue-1157-strip-client-metadata
Jun 24, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import test from "node:test"; | ||
| import assert from "node:assert/strict"; | ||
|
|
||
| const openaiHelper = await import("../../open-sse/translator/helpers/openaiHelper.ts"); | ||
|
|
||
| // Regression for upstream issue 9router#1157: Codex-origin requests carry a | ||
| // top-level `client_metadata` object. On the OpenAI->OpenAI chat-completions | ||
| // passthrough, `filterToOpenAIFormat` is the only sanitizer, and it forwarded | ||
| // `client_metadata` to api.openai.com, which rejects it with | ||
| // 400 "Unknown parameter: 'client_metadata'". It must be stripped alongside | ||
| // the other Claude/Codex-specific fields. | ||
| test("filterToOpenAIFormat strips top-level client_metadata (9router#1157)", () => { | ||
| const body = { | ||
| messages: [{ role: "user", content: "hi" }], | ||
| client_metadata: { user_id: "abc", session_id: "xyz" }, | ||
| metadata: { remove: true }, | ||
| anthropic_version: "2023-06-01", | ||
| }; | ||
|
|
||
| const result = openaiHelper.filterToOpenAIFormat(body); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| assert.equal("client_metadata" in result, false); | ||
| assert.equal("metadata" in result, false); | ||
| assert.equal("anthropic_version" in result, false); | ||
| assert.equal(result.messages.length, 1); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a dynamic
import()at the top level of a test file is non-standard and bypasses static import benefits. Use a staticimportstatement instead for better readability, standard static analysis, and tool compatibility.