Skip to content

fix: reject invalid provider cooldown bounds #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 1 commit into from
Jun 22, 2026
Merged

fix: reject invalid provider cooldown bounds #4589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/shared/validation/schemas/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,20 @@ export const providerCooldownSettingsSchema = z
minRetryCooldownMs: z.number().int().min(0).max(300000).optional(),
maxRetryCooldownMs: z.number().int().min(0).max(3600000).optional(),
})
.strict();
.strict()
.superRefine((value, ctx) => {
if (
typeof value.minRetryCooldownMs === "number" &&
typeof value.maxRetryCooldownMs === "number" &&
value.maxRetryCooldownMs < value.minRetryCooldownMs
) {
ctx.addIssue({
code: z.ZodIssueCode.custom,
message: "maxRetryCooldownMs must be greater than or equal to minRetryCooldownMs",
path: ["maxRetryCooldownMs"],
});
}
});

export const updateResilienceSchema = z
.object({
Expand Down
10 changes: 10 additions & 0 deletions tests/unit/resilience-provider-cooldown-api-3556.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ describe("providerCooldown in updateResilienceSchema", () => {
});
assert.equal(result.success, false, "Schema should reject unknown keys");
});

it("rejects providerCooldown max below min", () => {
const result = updateResilienceSchema.safeParse({
providerCooldown: {
minRetryCooldownMs: 120000,
maxRetryCooldownMs: 30000,
},
});
assert.equal(result.success, false, "Schema should reject contradictory cooldown bounds");
});
});

describe("providerCooldown roundtrip through mergeResilienceSettings", () => {
Expand Down
Loading