fix(cli): omniroute update revalidates npm cache with --prefer-online (#4376)

[diegosouzapw]

Closes #4376

Problem

@akbardwi pasted the exact output: on 3.8.30, omniroute update reported

Current version: 3.8.30
Latest version:  3.8.30
✔ You are running the latest version!

even though npm's latest dist-tag was already 3.8.31. So the updater told a user on an old build they were up to date.

Root cause

getLatestVersion() in bin/cli/commands/update.mjs ran npm view omniroute version without --prefer-online. npm view serves from npm's HTTP cache by default, so a stale cached entry (3.8.30) was returned instead of the live registry value (3.8.31).

Fix

Pass --prefer-online, which forces npm to revalidate its cache against the registry before answering. getLatestVersion is now exported and takes an injectable exec runner so the npm args are unit-testable.

Tests (TDD, RED→GREEN)

tests/unit/cli-update-prefer-online-4376.test.ts:

• getLatestVersion passes --prefer-online (+ still queries view omniroute version) — RED before the fix (function wasn't even exported).
• returns null when npm is unavailable.

node --test → 2/2 pass; existing cli-update-global-paths-3295.test.ts still 2/2 (no regression). typecheck:core clean, ESLint 0 errors.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[gemini-code-assist]

Code Review

This pull request updates the getLatestVersion function in bin/cli/commands/update.mjs to include the --prefer-online flag when querying npm, preventing stale cached versions from being returned. It also exports the function and allows dependency injection of the execution function for testing, with corresponding unit tests added in tests/unit/cli-update-prefer-online-4376.test.ts. The reviewer noted a potential TypeScript compilation error in the new test file where capturedArgs is initialized to null without an explicit type annotation, which would fail under strict null checks when an object is later assigned to it.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Under strict TypeScript configuration (strictNullChecks: true), initializing capturedArgs to null without an explicit type annotation infers its type as null. This will cause a compilation error when assigning an object to it on line 14. Specifying an explicit union type resolves this issue.

  let capturedArgs: { cmd: string; args: string[] } | null = null;

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.