Skip to content

chore(i18n): remove unused config helpers - #4482

Merged
diegosouzapw merged 2 commits into
diegosouzapw:release/v3.8.33from
KooshaPari:fix/quality-dead-code-baseline-4436
Jun 21, 2026
Merged

diegosouzapw merged 2 commits into
diegosouzapw:release/v3.8.33from
KooshaPari:fix/quality-dead-code-baseline-4436

Conversation

@KooshaPari

Copy link
Copy Markdown
Contributor

Summary

  • remove unused i18n config helper exports that Knip reports as dead code
  • reduce the dead-code ratchet total from 341 to 339 without changing runtime locale config exports

Validation

  • npx prettier --write src/i18n/config.ts
  • npx eslint src/i18n/config.ts --quiet
  • node node_modules/knip/bin/knip.js --reporter json --no-progress --no-exit-code > C:\Users\koosh\OmniRoute-upstream.git\knip-quality-after.json
    • DEAD_EXPORTS=240
    • DEAD_FILES=99
    • DEAD_TOTAL=339

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies src/i18n/config.ts by removing the unused convenience helpers DOCS_TARGET_LOCALES and getLanguage. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@diegosouzapw
diegosouzapw changed the base branch from main to release/v3.8.33 June 21, 2026 14:02
@diegosouzapw
diegosouzapw marked this pull request as ready for review June 21, 2026 14:58
@diegosouzapw
diegosouzapw self-requested a review as a code owner June 21, 2026 14:58
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@diegosouzapw
diegosouzapw merged commit 3959242 into diegosouzapw:release/v3.8.33 Jun 21, 2026
4 checks passed
@diegosouzapw diegosouzapw mentioned this pull request Jun 22, 2026
@KooshaPari
KooshaPari deleted the fix/quality-dead-code-baseline-4436 branch July 2, 2026 22:10
@KooshaPari
KooshaPari restored the fix/quality-dead-code-baseline-4436 branch July 3, 2026 10:07
tkgo11 pushed a commit to tkgo11/OmniRoute that referenced this pull request Sep 23, 2026
Removes dead exports DOCS_TARGET_LOCALES and getLanguage (zero callers, Knip-reported) and adds config-adapter coverage test.

Integrated into release/v3.8.33.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants