Repository navigation
fix(integration): restore codex and memory pipeline contracts - #4474
Merged
diegosouzapw merged 6 commits intoJun 21, 2026
Merged
diegosouzapw merged 6 commits into
diegosouzapw merged 6 commits into
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
diegosouzapw
force-pushed
the
fix/integration-codex-memory-4436
branch
from
June 21, 2026 11:58
8af611c to
a079455
Compare
diegosouzapw
marked this pull request as ready for review
June 21, 2026 11:58
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
diegosouzapw
pushed a commit
that referenced
this pull request
Jun 21, 2026
…4464) Thanks @KooshaPari! Merged the core of this PR (provider-asset shrink + budget gate + usage-rollup same-day cutoff fix + test), rebuilt scoped on release/v3.8.32. On review we dropped the codeqlAlerts 0->1 baseline loosening and the off-topic changes (the codex/memory contract fixes already landed via #4474; getProviderNames removal + cognitive baseline left out). Asset gate passes, rollup 22/22.
Merged
diegosouzapw
pushed a commit
to Witroch4/OmniRoute
that referenced
this pull request
Jun 21, 2026
…ouzapw#4474) Thanks @KooshaPari! Rebased onto release/v3.8.32 (clean cherry-pick — coexists with diegosouzapw#4467's specialty changes, 118/118 unit + 12/12 memory-pipeline integration). Codex fingerprint ordering + memory-search contract fixes land. (cherry picked from commit 21d61c6)
diegosouzapw
pushed a commit
to Witroch4/OmniRoute
that referenced
this pull request
Jun 21, 2026
…iegosouzapw#4464) Thanks @KooshaPari! Merged the core of this PR (provider-asset shrink + budget gate + usage-rollup same-day cutoff fix + test), rebuilt scoped on release/v3.8.32. On review we dropped the codeqlAlerts 0->1 baseline loosening and the off-topic changes (the codex/memory contract fixes already landed via diegosouzapw#4474; getProviderNames removal + cognitive baseline left out). Asset gate passes, rollup 22/22. (cherry picked from commit 911e1fb)
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…ouzapw#4474) Thanks @KooshaPari! Rebased onto release/v3.8.32 (clean cherry-pick — coexists with diegosouzapw#4467's specialty changes, 118/118 unit + 12/12 memory-pipeline integration). Codex fingerprint ordering + memory-search contract fixes land. (cherry picked from commit bd0344f)
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…iegosouzapw#4464) Thanks @KooshaPari! Merged the core of this PR (provider-asset shrink + budget gate + usage-rollup same-day cutoff fix + test), rebuilt scoped on release/v3.8.32. On review we dropped the codeqlAlerts 0->1 baseline loosening and the off-topic changes (the codex/memory contract fixes already landed via diegosouzapw#4474; getProviderNames removal + cognitive baseline left out). Asset gate passes, rollup 22/22. (cherry picked from commit e9bde79)
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…ouzapw#4474) Thanks @KooshaPari! Rebased onto release/v3.8.32 (clean cherry-pick — coexists with diegosouzapw#4467's specialty changes, 118/118 unit + 12/12 memory-pipeline integration). Codex fingerprint ordering + memory-search contract fixes land.
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…iegosouzapw#4464) Thanks @KooshaPari! Merged the core of this PR (provider-asset shrink + budget gate + usage-rollup same-day cutoff fix + test), rebuilt scoped on release/v3.8.32. On review we dropped the codeqlAlerts 0->1 baseline loosening and the off-topic changes (the codex/memory contract fixes already landed via diegosouzapw#4474; getProviderNames removal + cognitive baseline left out). Asset gate passes, rollup 22/22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompt_cache_keyis serialized beforeincludeRoot Cause
Integration Tests (2/2)was failing on upstreammainfor two unrelated contracts:open-sse/config/cliFingerprints.tsas the final serialization order. That order still placedincludebeforeprompt_cache_key, so the Codex OAuth Responses integration test observed the wrong key order.omniroute_memory_searchreusedtoMemoryRetrievalConfig()directly. With default settings, memory injection is disabled and the config becomesenabled: false/maxTokens: 0, so an explicit search returned no memories before relevance ranking could run.Validation
node --import tsx/esm --test --test-force-exit --test-concurrency=1 --test-name-pattern "Codex CLI fingerprint" tests/integration/chat-pipeline.test.tsnode --import tsx/esm --test --test-force-exit --test-concurrency=1 --test-name-pattern "memory search ranks query-relevant" tests/integration/memory-pipeline.test.tsnpx eslint open-sse/config/cliFingerprints.ts open-sse/executors/codex.ts open-sse/mcp-server/tools/memoryTools.ts --quietnpm run typecheck:core -- --pretty falsecheck:any-budget:t11, tracked artifacts