Repository navigation
fix(translator): strip Claude output_config before MiniMax - #4448
Merged
diegosouzapw merged 1 commit intoJun 20, 2026
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
MiniMax exposes a Claude-compatible endpoint but rejects Anthropic's extended `output_config` parameter (used to steer reasoning effort and structured output) with a generic 400 "invalid params" response. `prepareClaudeRequest()` now strips the entire `output_config` field for the `minimax` and `minimax-cn` providers before any downstream processing, so the field never reaches `translateRequest` or the executor. Anthropic Claude and other Claude-compatible upstreams that do accept `output_config` are unaffected. Ported from upstream decolua/9router#820 by @hiepau1231. Co-authored-by: hiepau1231 <hiepau1231@users.noreply.github.com> Inspired-by: decolua/9router#820
diegosouzapw
force-pushed
the
feat/port-pr-820-minimax-strip-output-config
branch
from
June 20, 2026 23:25
0aff92e to
a6ccfdc
Compare
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…apw#4448) Integrated into release/v3.8.32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output_configparameter (used to steer reasoning effort and structured output) with a generic 400 invalid params response.prepareClaudeRequest()now strips the entireoutput_configfield for theminimaxandminimax-cnproviders before any downstream processing, so the field never reachestranslateRequestor the executor.output_configare unaffected.The existing OmniRoute behaviour in
chatCore.tsonly strippedoutput_config.formatfor non-Anthropic providers (issue #1719) —output_config.effortstill leaked through to MiniMax and tripped the 400. This port closes that gap at the translator-helper layer.Provenance
Ported from upstream
decolua/9router#820by @hiepau1231. The OmniRoute port lives inprepareClaudeRequest()(TypeScript) instead of the upstream's JavaScript helper, mirroring the upstream architecture.Test plan
tests/unit/claude-helper-minimax-output-config.test.ts(3/3 cases —minimaxstrips,minimax-cnstrips,claudepreserves), RED before the fix → GREEN after.tests/unit/claude-cache-control-passthrough.test.ts+tests/unit/translator-claude-helper-thinking.test.ts(19/19 pass).npm run typecheck:core— clean.