Repository navigation
fix(providers): register Firecrawl and Jina Reader API-key validators (#4401) - #4412
Merged
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
diegosouzapw
force-pushed
the
fix/4401-webfetch-validators
branch
from
June 20, 2026 20:01
7eaecdd to
35fd4b2
Compare
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4401
Problem
Firecrawl and Jina Reader were added as
webFetch-kind providers in #2645 with their own executors (firecrawl-fetch,jina-reader-fetch), but no API-key validator was registered. The dashboard "Validate" step therefore fell through all three validator lookups and returned"Provider validation not supported", making it impossible to add these accounts through the standard UI flow.Fix
Register both providers in
SEARCH_VALIDATOR_CONFIGS(src/lib/providers/validation.ts), which auto-wires them intoSPECIALTY_VALIDATORS. Each probes the same endpoint + Bearer auth its executor already uses:firecrawl→POST https://api.firecrawl.dev/v1/scrapejina-reader→GET https://r.jina.ai/<url>validateSearchProvidermaps200/<500→ valid,401/403→ invalid key,>=500→ failure (so a credit-exhausted or rate-limited key still validates).Validation (TDD)
New
tests/unit/provider-validation-webfetch-4401.test.ts— fails on the unfixed code with"Provider validation not supported", passes after the fix (3/3). Existingprovider-validation-specialty.test.tsstays green (112/0).typecheck:coreclean, lint clean.