test(infra): isolate DATA_DIR per test process; raise Stryker concurrency 1→4

[diegosouzapw]

Quality Gate v2 / Fase 9 — Onda 2 foundation (unblocks the mutation baseline)

Onda 2 (mutation radiography + test pruning) needs a complete Stryker run, but the
nightly mutation job kept timing out: stryker.conf.json was pinned to concurrency: 1
because the covering node:test files raced on shared SQLite state, and a serial ~15k-mutant
run does not fit the budget (the 2026-06-16/17 nightly runs cancelled at the timeout).

Root cause

Every test process resolves DATA_DIR to the same default (~/.omniroute) when the
env var is unset (src/lib/dataPaths.ts::resolveDataDir). node:test spawns a process per
file and Stryker spawns one per sandbox, so concurrent processes opened the same on-disk
storage.sqlite → cross-file races:

• SQLite lock contention that hung npm run test:unit under high --test-concurrency (the
  ~95-min local hang), and
• the non-deterministic baseline that forced Stryker to concurrency: 1.

open-sse/utils/setupPolyfill.ts could not host the fix — it is imported by production
(bin/omniroute.mjs, proxyFetch.ts, proxyDispatcher.ts), where redirecting DATA_DIR
would point the live DB at a throwaway temp dir.

Fix

A test-only tests/_setup/isolateDataDir.ts gives each process its own temp DATA_DIR
when none is set (tests that set DATA_DIR explicitly still win), wired via --import into
the test/mutation/CI invocations. With the shared file gone, concurrency > 1 is
deterministic → stryker.conf.json raised to concurrency: 4.

Verified

Check	Result
Stryker dry-run A/B @ concurrency=4	❌ FAILS without the isolation import (account-fallback-service tap exit 9 — cross-file race) · ✅ PASSES with it
Full npm run test:unit with isolation	✅ 0 fail, and faster (DB lock contention gone). One chatcore-translation-paths timeout flake on one run did not reproduce and passes 3/3 isolated
New tests/unit/isolate-datadir.test.ts	✅ guards the contract (unique temp DATA_DIR when unset; explicit DATA_DIR respected)

Wiring

• tests/_setup/isolateDataDir.ts (new, test-only) + tests/unit/isolate-datadir.test.ts (guard)
• package.json: 13 test scripts
• stryker.conf.json: tap.nodeArgs + concurrency 1→4 + updated rationale comment
• .github/workflows/quality.yml: the TIA impacted-tests step
• .github/workflows/ci.yml: the 5 unit/coverage/integration commands
• .github/workflows/nightly-mutation.yml: timeout 120→180 (headroom for the first cold run before the incremental cache is seeded)

After merge, the next nightly (or a workflow_dispatch) should produce a complete
mutation report — the prerequisite for the Onda 2 radiography + pruning.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[gemini-code-assist]

Code Review

This pull request introduces test-only DATA_DIR isolation via a new utility tests/_setup/isolateDataDir.ts, which is imported across test scripts in package.json and stryker.conf.json to allow concurrent test execution without SQLite database state races. A regression test is also added to verify this isolation. The reviewer correctly identified a critical issue where child processes spawned by node:test inherit the parent's generated DATA_DIR, thereby bypassing the isolation guard and sharing the same directory. The suggested fix to detect generated paths and force unique directories for child processes is highly recommended.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Issue: Concurrent test processes still share the same DATA_DIR under node:test due to environment inheritance

When running npm run test:unit, the main node process imports isolateDataDir.ts and sets process.env.DATA_DIR to a temporary directory (e.g., /tmp/omniroute-test-XXXXXX).
Because node:test spawns child processes for each test file, these child processes inherit the parent's environment variables verbatim.
When a child process starts and imports isolateDataDir.ts, it sees that process.env.DATA_DIR is already set, so the if (!process.env.DATA_DIR) guard evaluates to false.
Consequently, all concurrent test files share the exact same temporary directory and SQLite database, re-introducing the cross-file state races and lock contentions during local test runs.

Solution

We can detect if process.env.DATA_DIR was automatically generated by a parent process (by checking if it contains the unique omniroute-test- prefix) and force the creation of a new unique directory for the current process. This ensures true isolation per test process while still respecting any explicit, user-defined DATA_DIR (which wouldn't contain the prefix).

Suggested change

	if (!process.env.DATA_DIR) {
	const dir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-test-"));
	process.env.DATA_DIR = dir;
	// Best-effort cleanup so a long suite run does not leak hundreds of temp DBs.
	process.on("exit", () => {
	try {
	fs.rmSync(dir, { recursive: true, force: true });
	} catch {
	// ignore — the OS reaps its temp dir eventually.
	}
	});
	}
	const isGenerated = process.env.DATA_DIR && process.env.DATA_DIR.includes("omniroute-test-");
	if (!process.env.DATA_DIR || isGenerated) {
	const dir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-test-"));
	process.env.DATA_DIR = dir;
	// Best-effort cleanup so a long suite run does not leak hundreds of temp DBs.
	process.on("exit", () => {
	try {
	fs.rmSync(dir, { recursive: true, force: true });
	} catch {
	// ignore — the OS reaps its temp dir eventually.
	}
	});
	}