Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces an index file open-sse/utils/stream/index.ts to export various stream-related modules. The review feedback correctly points out that using explicit .ts extensions in relative export paths is discouraged in TypeScript and can lead to compiler errors, suggesting they be omitted.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| export * from "./types.ts"; | ||
| export * from "./utils.ts"; | ||
| export * from "./responsesLifecycle.ts"; | ||
| export * from "./textualToolCalls.ts"; | ||
| export * from "./sseFormatters.ts"; | ||
| export * from "./errors.ts"; | ||
| export * from "./claudeLifecycle.ts"; | ||
| export * from "./openaiChunks.ts"; | ||
| export * from "./streamCore.ts"; |
There was a problem hiding this comment.
In TypeScript, exporting files with an explicit .ts extension is generally discouraged and can cause compiler errors (such as TS2691: 'An import path cannot end with a ".ts" extension') depending on the project's TypeScript configuration. It is recommended to omit the .ts extension in relative export paths to ensure compatibility with standard TypeScript module resolution and bundlers.
| export * from "./types.ts"; | |
| export * from "./utils.ts"; | |
| export * from "./responsesLifecycle.ts"; | |
| export * from "./textualToolCalls.ts"; | |
| export * from "./sseFormatters.ts"; | |
| export * from "./errors.ts"; | |
| export * from "./claudeLifecycle.ts"; | |
| export * from "./openaiChunks.ts"; | |
| export * from "./streamCore.ts"; | |
| export * from "./types"; | |
| export * from "./utils"; | |
| export * from "./responsesLifecycle"; | |
| export * from "./textualToolCalls"; | |
| export * from "./sseFormatters"; | |
| export * from "./errors"; | |
| export * from "./claudeLifecycle"; | |
| export * from "./openaiChunks"; | |
| export * from "./streamCore"; |
Part of Issue diegosouzapw#3594 modularization. Adds index.ts to re-export all stream modules for convenient imports.
|
Thanks, @oyi77 🙏. These stream extractions are currently additive — the new modules under |
Part of modularization effort (Issue #3594).
Adds
open-sse/utils/stream/index.tsto re-export all stream modules.Changes:
open-sse/utils/stream/index.ts(9 lines)Usage:
Depends on: All prior stream module PRs (#3917-#3927).