Repository navigation
feat(ui): add static news ticker in header cycling every 10 seconds with i18n support [defer to 3.9.0] - #3813
rafacpti23 wants to merge 2 commits into
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Review noteNo automated review issues were flagged (gemini-code-assist quota was exhausted). The feature adds a static news ticker in the header cycling every 10 seconds with i18n support. Could you rebase onto the current release branch ( |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Obrigado pelo empenho, @rafacpti23! 🙏 O componente em si (cleanup de interval/fetch,
Se você quiser transformar isso num recurso genérico — um feed de avisos configurável pelo operador (via settings/DB, sem conteúdo promocional fixo), com i18n via |
|
Thanks @rafacpti23 for this! As the title notes ( |
… states Adds the missing automated test for the news-ticker feature (PR diegosouzapw#3813): locale-exact / base-language / English fallback, safe rel+target on the external link, and null render on empty feed or fetch failure. Co-authored-by: Ramel Tecnologia <rafacpti@gmail.com>
|
Validei este PR contra o tip atual da
Empurrei para o seu branch um teste ( |
|
Obrigado, @rafacpti23! O news ticker está bem feito (i18n via
Deixo aberto, marcado para 3.9.0. Quando ajustar os itens acima, a gente revisa de novo! |
|
Thanks @rafacpti23! You marked this [defer to 3.9.0] in the title yourself, so I'm honoring that — leaving it open and parked for the 3.9.0 cycle rather than merging into |
|
Thank you for this, @rafacpti23 — the A header news ticker is a visible product/brand surface, so we're deciding it in the 3.9.0 cycle rather than mid-3.8.x — which is why this carries the When the 3.9.0 release branch opens, please re-open a focused PR against it — I'd love to land your version. The only small follow-up noted in the tracking issue is i18n-ing the hardcoded |
This PR implements a static news ticker banner in the dashboard header.
Key changes:
public/news/news.jsonfor managing announcements.NewsTickerReact component cycling through news items every 10 seconds.NewsTickercomponent in the central section of the globalHeader.tsxonly on the initial/home page.