Release v3.8.23 - #3693
Merged
Merged
Release v3.8.23#3693
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (1 file)
This PR contains only a file rename operation. All previous issues remain on unchanged files. Fix these issues in Kilo Cloud Reviewed by laguna-m.1-20260312:free · 186,978 tokens |
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
Integrated into release/v3.8.23
Integrated into release/v3.8.23
…3689) Integrated into release/v3.8.23
…ution (#3692) Integrated into release/v3.8.23
Integrated into release/v3.8.23
Integrated into release/v3.8.23
… (#3702) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… (#3703) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Integrated into release/v3.8.23
…API (#3712) Integrated into release/v3.8.23. Vertex dynamic model discovery — surfaces image models (imagen-*, gemini-*-image), embeddings and audio from the live Generative Language catalog, with cached→static fallback and the shared parseGeminiModelsList helper. Validated: parser test 5/5, typecheck:core clean.
Integrated into release/v3.8.23. Makes the #3588 reasoning token buffer safe and configurable: only inflates max_tokens when the model has a known, non-default output cap and the buffered value fits inside it; otherwise preserves/clamps the client limit. Adds the reasoningTokenBufferEnabled kill switch (default ON). Validated: combo-routing-engine 81/81, combo-config 25/25, combo-quality-validator-reasoning 12/12, phase1f 10/10, typecheck:core clean.
…54) (#3717) Phase 1g-1j of #3501: client 4062→3408 LOC. Pure extraction (ProviderPlaygroundPanel, useCommandCodeAuth, useExternalLinkFlow+ExternalLinkModal, useAuthFileHandlers) + loadConnProxies ReferenceError fix + phase1f test path fix. Co-authored-by: oyi77 <14921983+oyi77@users.noreply.github.com>
…rofileArn (#3722) Integrated into release/v3.8.23
…cation, and success-decay recovery (#3629) Integrated into release/v3.8.23
…opencode' CLI command (#3726) Integrated into release/v3.8.23
Integrated into release/v3.8.23
) (#3723) Integrated into release/v3.8.23
… every chatHelpers import #3692 added a lazy 'await import(proxyEgress)' for egress-IP visibility inside safeLogEvents, which is a sync function — an ES syntax error. It went unnoticed because typecheck:core does not cover src/sse and no test in the merge gates loaded chatHelpers via tsx; any consumer that did (chat-context-relay and chat-route-coverage suites, integration harnesses) failed at module load with 'await can only be used inside an async function'. safeLogEvents is fire-and-forget logging with an outer try/catch, so making it async (and 'void'-ing the single chat.ts call site) preserves behavior exactly. Validation: tests/unit/chat-context-relay.test.ts + chat-route-coverage.test.ts went from failing-at-load to green (+14 tests destravados).
… + combo/proxy audit fixes (#3699) Integrated into release/v3.8.23
…ops 403ing (#3728) Integrated into release/v3.8.23
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… auto-hide (#3729) Integrated into release/v3.8.23
Integrated into release/v3.8.23 — aligns upload-artifact to v7 (already used across ci.yml).
Integrated into release/v3.8.23 — actions/cache v4→v5.
Integrated into release/v3.8.23 — download-artifact v4→v8.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
|
|
||
| export function isEmergencyFallbackEnvEnabled(): boolean { | ||
| const raw = process.env.OMNIROUTE_EMERGENCY_FALLBACK; | ||
| return raw !== "false" && raw !== "0"; |
There was a problem hiding this comment.
WARNING: Emergency fallback env parser treats most typo/falsey values as enabled
OMNIROUTE_EMERGENCY_FALLBACK is documented as a disable switch, but isEmergencyFallbackEnvEnabled() only rejects lowercase "false" and "0". Values such as "False", " FALSE ", or an accidental empty string keep fallback enabled, so an operator may believe fallback is disabled while the runtime still redirects budget failures.
Suggested change
| return raw !== "false" && raw !== "0"; | |
| return raw?.trim() !== "" && raw?.trim().toLowerCase() !== "false" && raw?.trim().toLowerCase() !== "0"; |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Aligns zh-CN to en (hundreds of entries), translates batch-action labels + settings sidebar menu, adds categoryConfig/endpointTokenSaver keys, resolves __MISSING__ stubs. Sidebar/SidebarTab hardcoded strings replaced with t(). en.json purely additive (8 new sidebar.* keys, 0 removed); cli-i18n gate green. Integrated into release/v3.8.23.
- CHANGELOG: complete v3.8.23 section (28 bullets, 27 commits) - fix(webdav): resolve promise on writeStream finish, not req end — eliminates intermittent 500 on PUT update (writeStream may not have flushed at rename time) - test(autoCombo): stub DB calls from PR #3660 in tieredRotation.test.ts to prevent 5s timeout in vitest (getModelIntelligenceBySource DB init path) - chore(env-sync): add XDG_DATA_HOME + OMNIROUTE_OPENCODE_PLUGIN_DIR to IGNORE_FROM_CODE allowlist (introduced by PR #3726 setup-open-code.mjs, not OmniRoute config vars) - chore(cli): regenerated bin/cli/api-commands/*.mjs (7 new, 27 updated)
getNextFamilyFallback normalized dots-to-hyphens ("gemini-3.1-pro-high" →
"gemini-3-1-pro-high") but MODEL_FAMILIES keys use the literal dot form. The
lookup always missed, returning null for any model whose dots are part of the
name rather than a version separator.
Fallback: try MODEL_FAMILIES[lookupKey] ?? MODEL_FAMILIES[bareModel] so both
naming conventions are covered. Fixes T30 test (pre-existing since v3.8.22).
Adds all-time USD cost per API key in the API Key Manager, a per-key deep-link into the Cost Explorer (filtered + grouped by model), URL-param hydration of range/groupBy/apiKeyIds, and a '% used' quota display. Review adjustments: extracted URL-param parsers to a tested module (Rule #18), i18n'd the new strings (en + zh-CN), dropped the redundant webdav-handler entry already on release. Integrated into release/v3.8.23.
Replaces the Providers page configured-only toggle with All/Configured/Compact display modes (Compact = flat deduped grid, no-auth last). Persists the preference and migrates the legacy localStorage key. Rebased onto release/v3.8.23. Integrated into release/v3.8.23.
Adds the api_key_id dimension to generateSignature's SHA-256 hash so two callers with different API keys never receive each other's cached responses. Threads apiKeyId through checkSemanticCache + both write sites; migration 098 clears pre-existing key-less entries; unauthenticated requests stay isolated from keyed ones. 3 TDD tests. Integrated into release/v3.8.23.
…3708) resolveStreamFlag now applies the stream=false-when-omitted default for sourceFormat=openai-responses (same as the existing claude path), so spec-compliant /v1/responses upstreams that return JSON no longer fall through to the wildcard-Accept heuristic and trigger STREAM_EARLY_EOF / 502. Codex CLI (stream:true) and explicit text/event-stream clients unaffected. Integrated into release/v3.8.23.
- file-size baseline: re-freeze 8 files grown by PRs #3742/#3743/#3740 (cost drilldown, provider display modes, cache key isolation) - ARCHITECTURE.md: update executor count 55→60 (check:docs-counts drift) - .env.example: add OMNIROUTE_EMERGENCY_FALLBACK (#3741, env-doc-sync) - CHANGELOG: add formatted bullets for #3742, #3743, #3708, #3740, model-family-fallback fix; remove duplicate raw ### Fixed section
Three test files had net assertion removals after behavior-changing PRs: - chatcore-translation-paths: emergency fallback moved to routing layer (#3699) — add body error assertion + model-name guard - executor-vertex-extended: non-JSON is now Express API key (#3690) — add projects/-path guard to the express-key URL test - stream-utils: empty streams now emit error (#3685) — add code/message/ status/completePayload guards to both passthrough and translate variants All new assertions are meaningful (code enum value, 5xx range, non-empty message, onComplete must-not-fire contract).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[3.8.23] — TBD
✨ New Features
Emergency budget fallback: opt-out env switch
OMNIROUTE_EMERGENCY_FALLBACK(#3741 — thanks @zoispag): adds anOMNIROUTE_EMERGENCY_FALLBACKenvironment variable that disables the budget-exhaustion emergency reroute tonvidia/openai/gpt-oss-120bentirely when set tofalseor0. Default behavior (enabled) is unchanged.Auto-Combo: live model intelligence scoring via Arena ELO + models.dev (#3660 — thanks @pizzav-xyz): replaces the static fitness lookup with a 5-layer resolution chain (user override → Arena ELO → models.dev tiers → hardcoded map → neutral fallback). A sync pipeline auto-fetches Arena AI leaderboard ELO scores and derives intelligence tiers from models.dev capabilities; combo picks now update as leaderboard rankings change without any manual configuration.
Vertex AI: dynamic model discovery (#3712 — thanks @artickc): the
vertexprovider now queries the Generative Language models API at runtime to surface the full account catalog — including image-generation models (Imagen,gemini-*-image), embeddings, and partner models — instead of returning only the small hardcoded registry list.Vertex AI: self-tracked USD spend on the Limits page (#3724 — thanks @artickc): since the Google Cloud Billing API is inaccessible via the proxy credential, Vertex connections now track their own cumulative USD spend locally (based on token-cost accounting) and display it on the Limits page as "$ used since account added."
Gemini: rate-limit metadata for known per-model RPM/RPD caps (#3686 — thanks @hartmark): injects known rate-limit headers (RPM/RPD) for Gemini models that carry per-model limits (e.g. Gemma 4's 15 RPM / generous RPD), so the cooldown engine applies them correctly instead of locking out the whole account on daily-limit hits.
Model Lockout: full settings UI with success-decay recovery (#3629 — thanks @Chewji9875): end-to-end wiring of the per-model lockout feature — settings UI (enable/disable, configure thresholds), backend integration, structured error classification, and a success-decay mechanism that gradually recovers a locked model's fitness as successful calls accumulate.
🔧 Bug Fixes
@omniroute/opencode-pluginbundled in the npm tarball +omniroute setup opencodeCLI command (#3726 — thanks @herjarsa)safeLogEventsasync hotfix (thanks @diegosouzapw)top_pwhentemperatureis set (#3691 — thanks @zhiru)/v1/messages/count_tokensnow honors the connection's proxy assignment (#3699 — thanks @diegosouzapw)gemini-3.1-proHigh/Low budget tiers (#3696 — thanks @diegosouzapw)finishnotend(thanks @diegosouzapw): eliminates intermittent 500 on second PUT — write stream might not have flushed atrenameSynctime.getNextFamilyFallbacknormalizedgemini-3.1-pro-high→gemini-3-1-pro-highbut the map key uses dots. Pre-existing since v3.8.22.♻️ Code Quality
🌍 Internationalization
📝 Maintenance
#3590bullet lost on the v3.8.20 release branch (thanks @diegosouzapw)✅ Tests
#1731fast-skip suite restored (8 tests — thanks @diegosouzapw)Quality Gate
Coverage of commits since previous tag
v3.8.22..HEAD