fix(minimax): stop capping MiniMax-M3 / M2.7 max_tokens at 8192 (#3141)

[diegosouzapw]

Closes #3141

MiniMax-M3 had no model spec and capitalized MiniMax-M2.7 missed its lowercase spec (case-sensitive lookup) → both capped to the 8192 default. Adds the M3 spec (512K output), aliases the capitalized ids, and makes getModelSpec case-insensitive.

Regression test: tests/unit/minimax-m3-maxtokens.test.ts. Thanks @totaltube.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[gemini-code-assist]

Code Review

This pull request adds the MiniMax M3 model specification and updates the getModelSpec function to perform case-insensitive lookups for model IDs, aliases, and prefixes, resolving an issue where capitalized model IDs were incorrectly falling back to default token limits. It also introduces a comprehensive unit test suite to verify these changes. The review feedback suggests optimizing getModelSpec by using direct O(1) lookups and a lazy-initialized alias cache to eliminate redundant iterations and string lowercasing operations.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Performance & Simplicity Optimization for getModelSpec

The current implementation of getModelSpec performs multiple O(N) loops and repeatedly calls .toLowerCase() on keys and aliases on every single lookup. Since getModelSpec is called frequently during routing and translation, we can optimize this to O(1) for exact and alias lookups:

1. Direct O(1) Lookup: Since all keys in MODEL_SPECS are already lowercase, we can perform a direct MODEL_SPECS[lower] lookup. This completely eliminates the need for the case-insensitive exact match loop.
2. O(1) Alias Lookup: We can lazy-initialize an alias cache on the function object itself to make alias lookups O(1) instead of looping and calling .toLowerCase() repeatedly.
3. Optimized Prefix Matching: In the prefix matching loop, we can avoid calling key.toLowerCase() because all keys are already lowercase.

  const lower = modelId.toLowerCase();
  if (MODEL_SPECS[lower]) return MODEL_SPECS[lower];

  // Lazy-initialize alias cache for fast O(1) lookups
  let aliasCache = (getModelSpec as any).aliasCache as Record<string, ModelSpec> | undefined;
  if (!aliasCache) {
    aliasCache = {};
    for (const spec of Object.values(MODEL_SPECS)) {
      if (spec.aliases) {
        for (const alias of spec.aliases) {
          aliasCache[alias.toLowerCase()] = spec;
        }
      }
    }
    (getModelSpec as any).aliasCache = aliasCache;
  }

  const fromAlias = aliasCache[lower];
  if (fromAlias) return fromAlias;

  // Prefix matching (case-insensitive)
  for (const [key, spec] of Object.entries(MODEL_SPECS)) {
    if (key !== "__default__" && lower.startsWith(key)) return spec;
  }

  return undefined;

[kilo-code-bot]

SUGGESTION: Comment language inconsistency

This comment is in Portuguese ("Buscas por alias") while the rest of the codebase uses English comments. Should be "Alias lookups (case-insensitive)" for consistency.

[kilo-code-bot]

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	1

Issue Details (click to expand)

WARNING

File	Line	Issue
src/shared/constants/modelSpecs.ts	408-412	resolveModelAlias function is not case-insensitive, inconsistent with getModelSpec

SUGGESTION

File	Line	Issue
src/shared/constants/modelSpecs.ts	380	Comment in Portuguese instead of English

Other Observations (not in diff)

Issues found in unchanged code that cannot receive inline comments:

File	Line	Issue
src/shared/constants/modelSpecs.ts	316-322	MiniMax-M3 spec missing supportsVision field (other similar models explicitly declare it)
src/shared/constants/modelSpecs.ts	386-388	Case-insensitive prefix matching may cause unexpected matches (e.g., "minimax-m3-extra" would match "minimax-m3") - pre-existing behavior now case-insensitive
tests/unit/minimax-m3-maxtokens.test.ts	-	New tests don't cover resolveModelAlias case-insensitivity

Files Reviewed (2 files)

• src/shared/constants/modelSpecs.ts - 2 issues
• tests/unit/minimax-m3-maxtokens.test.ts - 1 observation

---

Fix these issues in Kilo Cloud

---

_{Reviewed by nemotron-3-ultra-550b-a55b-20260604:free · 1,078,002 tokens}