fix(handler): provide fallback for connectionId when undefined

[androw]

Summary

• Add fallback when connectionId is undefined
• Fix kilo calls not being logged to call_logs

Related Issues

• Related to [BUG] requests to auto not logged #3003

Validation

• npm run lint
• npm run test:unit
• npm run test:coverage
• Coverage is still >= 60% for statements, lines, functions, and branches
• SonarQube PR analysis is green or any remaining issues are explicitly documented below

Tests Added Or Updated

• List every changed or added automated test file.
• If no production code changed, state that here.

Coverage Notes

• If this PR changes src/, open-sse/, electron/, or bin/, explain which tests cover the change.
• If coverage moved down in any touched file, explain why and what follow-up task will recover it.

Reviewer Notes

• Call out any risky areas, migrations, feature flags, or manual validation that reviewers should know about.

[gemini-code-assist]

Code Review

This pull request introduces a fallback for connectionId using credentials?.connectionId when saving call logs in open-sse/handlers/chatCore.ts. The reviewer noted that applying this fallback locally only addresses call logging, leaving other critical downstream systems (such as usage persistence, quota tracking, and request logging) vulnerable to receiving undefined. To ensure consistency, the reviewer suggested resolving the fallback once at the beginning of the handleChatCore function.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

While adding a fallback for connectionId in saveCallLog is helpful, applying this fallback locally only fixes call logging. Many other critical systems in handleChatCore rely on connectionId and will still receive undefined if the parameter is not provided. These include:

1. Usage Persistence: persistFailureUsage (line 1702) and saveRequestUsage (line 5200)
2. Quota Tracking: persistCodexQuotaState (lines 1771, 1825, 1830) which updates the provider connection in the database
3. Request Logging & Pending Tracking: trackPendingRequest and appendRequestLog calls throughout the handler

If connectionId is undefined, updateProviderConnection(connectionId, ...) will be called with undefined, failing to persist the quota state.

Recommendation:
Resolve the fallback once at the very beginning of handleChatCore by reassigning the parameter:

connectionId = connectionId || credentials?.connectionId || undefined;

This ensures that all downstream logging, tracking, and database persistence systems automatically and consistently benefit from the fallback.

[kilo-code-bot]

Code Review Summary

Status: No New Issues Found | Recommendation: Merge (existing comment addressed)

Files Reviewed (1 file)

• open-sse/handlers/chatCore.ts — fallback chain for connectionId in saveCallLog()

---

_{Reviewed by step-3.7-flash-20260528 · 319,230 tokens}