Remove duplicate lowercase db-apikeys-crud.test.ts from tracking - #3125
diegosouzapw merged 4 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes a test file that verified the functionality of the API keys database, including key creation, permission updates, validation, and model access rules. As there are no review comments, I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…ve-duplicate-lowercase
This hotfix's purpose is removing the duplicate lowercase db-apikeys-crud.test.ts. The 127.0.0.1 -> localhost OAuth redirect change is unrelated and reverses a documented decision (Google native-app handoff prefers loopback IP; localhost can resolve to ::1 and hit firewall/name-resolution edge cases). Keeping only the test-file removal.
|
Thanks, @juandisay! 🙏 Good catch on the case-insensitive collision — |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (1 files)
Reviewed by nemotron-3-super-120b-a12b-20230311:free · 581,157 tokens |
…gosouzapw#3125) * remove duplicate lowercase db-apikeys-crud.test.ts from tracking * Changed redirecURI for google OAuth * revert: keep Google OAuth redirect on 127.0.0.1 (out-of-scope change) This hotfix's purpose is removing the duplicate lowercase db-apikeys-crud.test.ts. The 127.0.0.1 -> localhost OAuth redirect change is unrelated and reverses a documented decision (Google native-app handoff prefers loopback IP; localhost can resolve to ::1 and hit firewall/name-resolution edge cases). Keeping only the test-file removal. --------- Co-authored-by: juandisay <juandisay@example.com> Co-authored-by: diegosouzapw <diegosouza.pw@gmail.com>
…ors hall Adds entries for diegosouzapw#3097, diegosouzapw#3101 (deepseek-web diegosouzapw#2942/diegosouzapw#2820), diegosouzapw#3104, diegosouzapw#3105, diegosouzapw#3107, diegosouzapw#3109, diegosouzapw#3111, diegosouzapw#3113, diegosouzapw#3115, diegosouzapw#3122, diegosouzapw#3125, diegosouzapw#3127, diegosouzapw#3129, plus a Contributors section crediting all v3.8.9 contributors. Stamps the 3.8.9 release date.
…gosouzapw#3125) * remove duplicate lowercase db-apikeys-crud.test.ts from tracking * Changed redirecURI for google OAuth * revert: keep Google OAuth redirect on 127.0.0.1 (out-of-scope change) This hotfix's purpose is removing the duplicate lowercase db-apikeys-crud.test.ts. The 127.0.0.1 -> localhost OAuth redirect change is unrelated and reverses a documented decision (Google native-app handoff prefers loopback IP; localhost can resolve to ::1 and hit firewall/name-resolution edge cases). Keeping only the test-file removal. --------- Co-authored-by: juandisay <juandisay@example.com> Co-authored-by: diegosouzapw <diegosouza.pw@gmail.com>
…ors hall Adds entries for diegosouzapw#3097, diegosouzapw#3101 (deepseek-web diegosouzapw#2942/diegosouzapw#2820), diegosouzapw#3104, diegosouzapw#3105, diegosouzapw#3107, diegosouzapw#3109, diegosouzapw#3111, diegosouzapw#3113, diegosouzapw#3115, diegosouzapw#3122, diegosouzapw#3125, diegosouzapw#3127, diegosouzapw#3129, plus a Contributors section crediting all v3.8.9 contributors. Stamps the 3.8.9 release date.
…gosouzapw#3125) * remove duplicate lowercase db-apikeys-crud.test.ts from tracking * Changed redirecURI for google OAuth * revert: keep Google OAuth redirect on 127.0.0.1 (out-of-scope change) This hotfix's purpose is removing the duplicate lowercase db-apikeys-crud.test.ts. The 127.0.0.1 -> localhost OAuth redirect change is unrelated and reverses a documented decision (Google native-app handoff prefers loopback IP; localhost can resolve to ::1 and hit firewall/name-resolution edge cases). Keeping only the test-file removal. --------- Co-authored-by: juandisay <juandisay@example.com> Co-authored-by: diegosouzapw <diegosouza.pw@gmail.com>
…ors hall Adds entries for diegosouzapw#3097, diegosouzapw#3101 (deepseek-web diegosouzapw#2942/diegosouzapw#2820), diegosouzapw#3104, diegosouzapw#3105, diegosouzapw#3107, diegosouzapw#3109, diegosouzapw#3111, diegosouzapw#3113, diegosouzapw#3115, diegosouzapw#3122, diegosouzapw#3125, diegosouzapw#3127, diegosouzapw#3129, plus a Contributors section crediting all v3.8.9 contributors. Stamps the 3.8.9 release date.
This Pull Request resolves a case-sensitivity issue in the Git index where two files with different casings for the database API Keys unit tests (
db-apiKeys-crud.test.tsanddb-apikeys-crud.test.ts) were both tracked by Git.On case-insensitive filesystems (like macOS and Windows), this duplication causes conflicts during Git operations, silent test-file truncation (regression from 542 lines to 188 lines), and prevents changes from being staged.
Root Cause
tests/unit/db-apiKeys-crud.test.tsandtests/unit/db-apikeys-crud.test.tsas separate files in the repository history.git add).Proposed Changes
tests/unit/db-apikeys-crud.test.ts(188 lines) from the Git index.tests/unit/db-apiKeys-crud.test.ts(with all 54 test cases) as the single tracked path.Behavior Comparison
Expected Behavior
git statusremains clean after resets or checkouts.tests/unit/db-apiKeys-crud.test.tsstage successfully usinggit add.Actual Behavior (Before Fix)
git statusautomatically flaggedtests/unit/db-apiKeys-crud.test.tsas modified, even immediately after agit reset --hard.git addfailed silently, leaving the file under "Changes not staged for commit".Steps to Reproduce (on macOS/Windows)
Related Issue
#3123