Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a skills field (defaulting to an empty array) and hardcodes the stream parameter to true within the CommandCodeExecutor and its validation logic. Corresponding unit tests have been updated to align with these changes. Feedback suggests making the skills field configurable via the input body to increase flexibility. Additionally, it is recommended to refactor the validation logic to utilize the CommandCodeExecutor directly, which would eliminate code duplication and prevent potential desynchronization as the API evolves.
| }, | ||
| memory: "", | ||
| taste: "", | ||
| skills: [], |
There was a problem hiding this comment.
Instead of hardcoding skills to an empty array, consider allowing it to be passed from the input body if present. This would make the executor more flexible for clients that might want to leverage specific Command Code skills while still defaulting to an empty array as required by the upstream wrapper.
| skills: [], | |
| skills: Array.isArray(input.skills) ? input.skills : [], |
| }, | ||
| memory: "", | ||
| taste: "", | ||
| skills: [], |
There was a problem hiding this comment.
The Command Code request wrapper structure and headers are now duplicated between this validator and the CommandCodeExecutor. This duplication (including the hardcoded version 0.24.1 and the new skills field) increases the risk of desync as the provider API evolves.
Consider refactoring validateCommandCodeProvider to use the CommandCodeExecutor directly to centralize the payload transformation and header logic. This pattern is already established in this file for other providers (e.g., validateClaudeOAuthInline at line 658).
- Force skills: "" and params.stream: true in Command Code wrapper - Align validation probe payload with upstream-required shape - Default validation model to deepseek/deepseek-v4-flash Co-authored-by: ddarkr <ddarkr@users.noreply.github.com>
|
✅ Merged into All 5 commits cherry-picked and integrated. The Command Code executor now properly includes |
…pw#2271) - Force skills: "" and params.stream: true in Command Code wrapper - Align validation probe payload with upstream-required shape - Default validation model to deepseek/deepseek-v4-flash Co-authored-by: ddarkr <ddarkr@users.noreply.github.com>
…2271, diegosouzapw#2273 - diegosouzapw#2269: ignore .playwright-mcp/ artifacts (@backryun) - diegosouzapw#2271: Command Code stream payload fix (@ddarkr) - diegosouzapw#2273: Android/Termux headless support (@t-way666)
…pw#2271) - Force skills: "" and params.stream: true in Command Code wrapper - Align validation probe payload with upstream-required shape - Default validation model to deepseek/deepseek-v4-flash Co-authored-by: ddarkr <ddarkr@users.noreply.github.com>
…2271, diegosouzapw#2273 - diegosouzapw#2269: ignore .playwright-mcp/ artifacts (@backryun) - diegosouzapw#2271: Command Code stream payload fix (@ddarkr) - diegosouzapw#2273: Android/Termux headless support (@t-way666)
…pw#2271) - Force skills: "" and params.stream: true in Command Code wrapper - Align validation probe payload with upstream-required shape - Default validation model to deepseek/deepseek-v4-flash Co-authored-by: ddarkr <ddarkr@users.noreply.github.com>
…2271, diegosouzapw#2273 - diegosouzapw#2269: ignore .playwright-mcp/ artifacts (@backryun) - diegosouzapw#2271: Command Code stream payload fix (@ddarkr) - diegosouzapw#2273: Android/Termux headless support (@t-way666)
Summary
skills: ""andparams.stream: true.deepseek/deepseek-v4-flash.Verification
node --import tsx/esm --test tests/unit/command-code-executor.test.tsnode --import tsx/esm --test --test-name-pattern="validateCommandCodeProvider" tests/unit/provider-validation-specialty.test.tsnode --import tsx/esm --test --test-name-pattern="Command Code" tests/unit/responses-handler.test.tsnpm run typecheck:core