Repository navigation
feat(api-keys): add rename support in API key modal - #1796
Merged
diegosouzapw merged 1 commit intoApr 30, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
andrewmunsell
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to rename API keys directly within the permissions modal. Key changes include updating the handleUpdatePermissions function to include the new name in the PATCH request, adding a name input field to the PermissionsModal UI, and implementing corresponding E2E and integration tests. Feedback focuses on improving the validation flow by checking the raw input before sanitization, adding a maxLength attribute to the UI input for better user experience, and resolving the inconsistency between the frontend (100 characters) and backend (200 characters) name length limits.
Add an editable key name field at the top of the permissions modal, allowing users to rename API keys alongside existing permission settings. The backend already supported name updates via PATCH /api/keys/:id — this wires the UI to send the name field and refreshes the key list on success. Changes: - Add keyName state and text input to PermissionsModal - Update handleUpdatePermissions to validate and send name in PATCH body - Add integration test for rename via PATCH (valid, empty, too-long names) - Update E2E mock to handle PATCH requests
andrewmunsell
force-pushed
the
emdash/rename-api-keys-45un3
branch
from
April 30, 2026 00:30
c581aa7 to
c86c43f
Compare
Merged
diegosouzapw
pushed a commit
that referenced
this pull request
Apr 30, 2026
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sumary
Add an editable key name field at the top of the permissions modal, allowing users to rename API keys alongside existing permission settings.
The backend already supported name updates via PATCH /api/keys/:id — this wires the UI to send the name field and refreshes the key list on success.
Changes:
Tests Added Or Updated