Repository navigation
test(db): preserve driver contracts across Node and Bun - #16149
Merged
Merged
Conversation
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQLite regression fixture expected the
better-sqlite3constructor to run under Bun, although the production factory deliberately excludes Node drivers there. The Linux and Windows Bun jobs therefore failed the network-report assertion before this change.Make the existing case assert each runtime's contract: Node still enables network exclusion during construction and restores the caller setting after a thrown constructor; Bun requests only
bun:sqlite, never constructs the Node addon, and preserves the caller setting. Production code and existing skip conditions are unchanged.Validation
On release source
7510677f2f8f5317f1947284dab650d01333915d, using the official Bun 1.4.2 binary (revision744846f84) and Node 24.21.0:The mutation controls remove network exclusion, remove restoration, and allow the Node addon under Bun. Each uses the same frozen fixture in a disposable copy. Prettier, focused ESLint, file-size, test discovery and changelog checks pass. The independent review found no SPEC or Standards blockers.
Core and dashboard typechecks, cyclomatic complexity and cognitive complexity all pass on the frozen two-file snapshot. Local runtime testing was on Linux. Hosted Bun compatibility also passed on Linux and Windows, each with 25 passing tests and zero failures on Bun 1.4.2. This addresses one failure within #15306 and does not certify the full release pipeline.
Refs #15306