Repository navigation
test(notion): align catalog fixture with merged model additions - #16138
Merged
diegosouzapw merged 1 commit intoOct 10, 2026
Merged
Conversation
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Notion executor suite still expected the old 17-entry public model catalog after merged #16113 intentionally added 20 entries. This made its strict catalog equality fail on the release base.
Add those exact 20 model IDs to the literal expected array. The 17 previous IDs, their relative order, the strict equality and the rejection of internal codenames remain intact. Production, mocks, timeouts, configuration and baselines are unchanged.
Refs #15306
This fixes one base-suite failure; it does not close the broader CI remediation issue.
Validation
On base
122b43b35dbacab03ea67d0f0b46e713280ccd86, the unchanged original fixture reproduced 39 passes / 1 failure. After updating only the expected array, a cold process passed 40/40. Four related Notion files passed 33/33, with no skipped or cancelled tests.Independent source/AST review confirmed 126 assertions, 40 tests and 9 suites preserved; 125 assertion expressions and every byte outside the expected array are unchanged. The 20 additions exactly match the merged #16113 catalog patch, giving 37 unique literal IDs. This is an outdated-expectation correction, so the fixture hash intentionally changes between the original failing and corrected runs; no production-fix TDD claim is made.
Tests used synthetic state established before imports and blocked external traffic. No live Notion account or model availability was tested.
Focused ESLint/Prettier, file-size, changelog integrity, test discovery, core/dashboard typechecks and both complexity gates passed. Independent SPEC/Standards review found no blockers. Normal automatic commit hooks preserved both candidate hashes. Source/test, anti-masking and PR-evidence policies passed against the actual committed diff; the earlier precommit zero-file policy runs were explicitly treated as NOP. Hosted CI and merge remain pending.