Repository navigation
test(ui): stabilize real ProviderIcon lazy fallback coverage - #16134
Merged
diegosouzapw merged 2 commits intoOct 10, 2026
Merged
Conversation
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ProviderIcon regression fixture asserted CDN fallback before the real lazy catalog had loaded. Await the real loader and unmount every React root between cases. Under the full worker pool, cold evaluation of the icon dependency can also exceed the five-second deadline and leave React act pending, causing a cascade of empty-DOM failures.
Prepare the real catalog during test collection and explicitly verify the initial generic placeholder followed by the expected CDN fallback. Production still uses its unchanged lazy loader. The original 93 cases and 32 assertion expressions remain intact and ordered; one loading-state case adds four assertions. No catalog mock, timeout increase, test exclusion or baseline change.
Refs #15306. This is one fixture correction in the CI umbrella.
Validation
The catalog is evaluated before individual assertions, so the added loading-state test does not certify cold catalog transformation inside an individual test or cold-network performance. The broader465-file diagnostic had other failures/runner errors and was not rerun as a green claim. Full CI and release acceptance remain separate.