Skip to content

test(ui): stabilize real ProviderIcon lazy fallback coverage - #16134

Merged
diegosouzapw merged 2 commits into
release/v3.8.52from
fix/15306-provider-icon-fixture-1010
Oct 10, 2026
Merged

diegosouzapw merged 2 commits into
release/v3.8.52from
fix/15306-provider-icon-fixture-1010

Conversation

@diegosouzapw

@diegosouzapw diegosouzapw commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

The ProviderIcon regression fixture asserted CDN fallback before the real lazy catalog had loaded. Await the real loader and unmount every React root between cases. Under the full worker pool, cold evaluation of the icon dependency can also exceed the five-second deadline and leave React act pending, causing a cascade of empty-DOM failures.

Prepare the real catalog during test collection and explicitly verify the initial generic placeholder followed by the expected CDN fallback. Production still uses its unchanged lazy loader. The original 93 cases and 32 assertion expressions remain intact and ordered; one loading-state case adds four assertions. No catalog mock, timeout increase, test exclusion or baseline change.

Refs #15306. This is one fixture correction in the CI umbrella.

Validation

  • Original asynchronous fixture defect: 86 passed / 7 failed → 93/93 after awaiting imports. Hosted CI then exposed the separate deadline problem.
  • The intact PR fixture reproduced the hosted cascade locally: a canonical 20-worker selection of 20 files had 132 passed / 91 failed. The same selection with one worker passed223/223. Instrumentation measured actual catalog evaluation at16.396s versus2.348s; global import settling added approximately1ms.
  • The corrected fixture passes the same 20-worker selection: 224/224, zero skipped or failed, in41.919s. Its additional case explains the count difference. Isolated fixture94/94; fixture plus three related files105/105; prototype-collision suite4/4. These selections overlap and must not be summed.
  • AST preservation confirms all original cases/assertions, plus the new case. Focused ESLint, Prettier, file-size, discovery, changelog, core/dashboard typechecks and both full complexity checks passed. Independent SPEC/Standards review found no blocking issue.
  • Node24.21.0; synthetic HOME/DATA_DIR/plugins/cache/temp; outgoing network denied. The direct icon fixtures attempted no external connections. The20-file group had33 blocked version-discovery attempts in other fixtures, zero permitted traffic.

The catalog is evaluated before individual assertions, so the added loading-state test does not certify cold catalog transformation inside an individual test or cold-network performance. The broader465-file diagnostic had other failures/runner errors and was not rerun as a green claim. Full CI and release acceptance remain separate.

@github-actions

Copy link
Copy Markdown
Contributor

CI Coverage Report

  • Coverage job: skipped
  • PR test policy: success

Coverage artifact was not available for this run.

@diegosouzapw diegosouzapw changed the title test(ui): await ProviderIcon lazy fallback before assertions test(ui): stabilize real ProviderIcon lazy fallback coverage Oct 10, 2026
@diegosouzapw
diegosouzapw merged commit a7b4206 into release/v3.8.52 Oct 10, 2026
28 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant