Repository navigation
fix(video): protect retained raw transcript fields - #16128
Merged
Merged
Conversation
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raw video
transcript/audioTranscriptfields could remain in persisted request details and disk artifacts when video description failed ormaxVideosleft a sibling video unchanged. Mark these requests as observed even with zero replacements; after matching rendered-description shadows, apply the existing structural redactor to raw siblings on the retained copy. Preserve the provider payload and ordinary non-video retention.Defined empty strings and
nullintentionally activate the same conservative retention/cache/Memory policy; absent fields and non-video metadata do not. Document this bounded contract in GUARDRAILS and its 66 translations. The source entry was fully synchronized on the base, so only its 199 source/target/timestamp fields are updated; all other entries and text outside the inserted paragraphs are preserved.Refs #12430 (item 5, unreplaced raw-video residual). This is a partial delivery. The tracker remains open for its broader end-to-end acceptance; related STT/provenance work in #15780/#16061 is unchanged.
Validation:
The HTTP adapter runs real route/guardrail/logging code with synthetic description/inference and isolated DB/plugins, blocking external sockets. It does not exercise ffmpeg/STT, a real provider account, a full Next server, or every external store/plugin sink. No merge or deployment is performed here.