Repository navigation
fix(executors): sanitize web provider error boundaries - #16125
Merged
diegosouzapw merged 1 commit intoOct 10, 2026
Merged
Conversation
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DuckDuckGo upstream error
typeand anti-abuseoverrideCodefields could reach the executor response without canonical sanitization. Sanitize the normalized message atprocessResponsebefore serializing it, preserving the existing status and JSON envelope. Apply the same protection to the local DuckDuckGo and Copilot M365 error helpers as preventive hardening; their current callers did not demonstrate an active leak.Refs #15159 (E-03 and the adjacent DuckDuckGo response boundary). This is a partial umbrella delivery: the custom error envelopes remain supported by the error-sanitization contract, and this PR does not claim to convert every builder to
buildErrorBodyor complete the 78-item audit.Validation:
executemethod. It checks synthetic credentials/private paths/stack frames, benign error text, 418 without retry, status/envelope preservation, and non-reflection of unstructured HTML.7858333(115/116); it is not reported as an all-green run. Related Vitest suite: 6/6 pass.The focused fixture uses temporary data/plugin paths and blocks sockets. These checks establish the executor response contract, not live upstream acceptance or exposure through the final HTTP route. Hosted CI remains authoritative for integration; no merge is performed here.