Skip to content

fix(docs): validate migration counts across localized READMEs - #15982

Merged
diegosouzapw merged 2 commits into
release/v3.8.52from
fix/14574-readme-migration-count-drain
Oct 9, 2026
Merged

diegosouzapw merged 2 commits into
release/v3.8.52from
fix/14574-readme-migration-count-drain

Conversation

@diegosouzapw

Copy link
Copy Markdown
Owner

The migration-count check did not cover localized README database rows, allowing the mirrors to drift. All 66 configured localized READMEs now show the measured 202 SQL migrations instead of 193, with numeral-only edits that preserve the surrounding translations.

The existing strict docs-counts gate now checks each localized database row. It distinguishes the module count from the migration count, supports ASCII, Arabic and Persian digits, and rejects missing, duplicated or ambiguous rows. The existing tally behavior for missing files is unchanged; this change validates the configured mirrors that exist.

Closes #14574.

Evidence

  • TDD: the new tests/unit/readme-migration-count-14574.test.ts failed all 11 cases before implementation and passed all 11 afterward. The complete selected importer set passed 85 tests in 7 unique files, with no failures or skips.
  • Regression cases cover a stale number, a correct count elsewhere in the file, an incorrect module count masking the migration count, translated word order, Arabic/Persian digits, malformed rows, and integration with the strict tally.
  • npm run check:docs-all, npm run typecheck:core, npm run typecheck:noimplicit:core, lint, file-size, cyclomatic/cognitive ratchets, discovery and changelog gates passed.
  • Independent review confirmed the 66 README diffs each change only the migration numeral; normal commit hooks preserved this shape.
  • Dashboard check exits 1 with exactly the same three diagnostic groups as clean base 61e07fb7e0d4e1e76111495d3718c9e4d06d2a62: useModelImportHandlers.ts TS2339 (17), TS2345 (1), and engineConfigSave.ts TS2345 (1). No dashboard baseline was changed.

No database migration, locale regeneration or runtime behavior is changed by this PR.

Comment thread scripts/check/lib/readmeMigrationCount.mjs Dismissed
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

CI Coverage Report

  • Coverage job: skipped
  • PR test policy: success

Coverage artifact was not available for this run.

@diegosouzapw
diegosouzapw merged commit 53411de into release/v3.8.52 Oct 9, 2026
30 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: 65 README mirrors still say 178 migrations, and the docs-counts gate does not cover them

2 participants