Repository navigation
fix(dashboard): reset connection test modal state in the open handler - #15872
Merged
Merged
Conversation
Contributor
CI Coverage Report
Coverage artifact was not available for this run. PR Test PolicyThis PR changes production code in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base-red on the
release/v3.8.52tip:npm run lintfails with 1 error —react-hooks/set-state-in-effectinsrc/shared/components/ConnectionTestButton.tsx:41(added by #15138). The loading effect resetloading/error/answer/savedsynchronously before fetching.Fix: those four resets move into the button's
onClick(the only place that opens the modal), right beforesetOpen(true); the effect keeps only the fetch and its async setters. Same visible behavior on every open.Validation:
eslinton the file exit 0;tests/unit/ui/connection-test-message.test.tsx(vitest.config.ts) 9/9 (+1 skipped), same as on the tip.