Skip to content

fix(dashboard): reset connection test modal state in the open handler - #15872

Merged
diegosouzapw merged 1 commit into
release/v3.8.52from
fix/release-v3.8.52-basereds-1008d
Oct 8, 2026
Merged

diegosouzapw merged 1 commit into
release/v3.8.52from
fix/release-v3.8.52-basereds-1008d

Conversation

@diegosouzapw

Copy link
Copy Markdown
Owner

Base-red on the release/v3.8.52 tip: npm run lint fails with 1 error — react-hooks/set-state-in-effect in src/shared/components/ConnectionTestButton.tsx:41 (added by #15138). The loading effect reset loading/error/answer/saved synchronously before fetching.

Fix: those four resets move into the button's onClick (the only place that opens the modal), right before setOpen(true); the effect keeps only the fetch and its async setters. Same visible behavior on every open.

Validation: eslint on the file exit 0; tests/unit/ui/connection-test-message.test.tsx (vitest.config.ts) 9/9 (+1 skipped), same as on the tip.

@diegosouzapw
diegosouzapw merged commit 6e73e2c into release/v3.8.52 Oct 8, 2026
9 of 13 checks passed
diegosouzapw pushed a commit that referenced this pull request Oct 8, 2026
…15732)

Validated on the release tip with a clean npm ci (exit 0), npm 10 and 11.15.0 ci --dry-run, check-lockfile, check-deps, typecheck:core, size-limit CLI and npm run lint (the single lint error was a pre-existing base-red fixed in #15872).
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

CI Coverage Report

  • Coverage job: skipped
  • PR test policy: failure

Coverage artifact was not available for this run.

PR Test Policy

This PR changes production code in src/, open-sse/, electron/, or bin/ without accompanying automated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant