Repository navigation
fix(open-sse): reuse the verdict read once for a replayed shape refusal - #15737
Merged
diegosouzapw merged 1 commit intoOct 8, 2026
Conversation
maxmad64bis
marked this pull request as ready for review
October 7, 2026 18:37
maxmad64bis
force-pushed
the
fix/shape-replay-verdict-reread
branch
from
October 7, 2026 18:42
0eb81c9 to
8dc5469
Compare
maxmad64bis
marked this pull request as draft
October 7, 2026 20:23
The replay reread the refused body before scoring; the first read now travels to the replay.
maxmad64bis
force-pushed
the
fix/shape-replay-verdict-reread
branch
from
October 7, 2026 20:28
8dc5469 to
3a7b978
Compare
maxmad64bis
marked this pull request as ready for review
October 7, 2026 20:38
diegosouzapw
merged commit Oct 8, 2026
940b646
into
diegosouzapw:release/v3.8.52
29 of 52 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A replayed shape refusal is read twice before scoring: once to decide the replay and again inside the replay. The verdict read the first time now travels to the replay, so the refused body is read once and the same verdict reaches scoring.
Related Issues
Validation
npm run lintTests Added Or Updated
Coverage Notes
Reviewer Notes