Repository navigation
fix(compression): use Unicode-aware word boundaries in Russian rule packs (#15677) - #15719
Merged
Merged
Conversation
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
…ru-compression-boundary # Conflicts: # open-sse/services/compression/languageDetector.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15677
Root cause
JS
\bis ASCII-only and the Russian packs compiled with flagsgi(nou), so 26 of 32 rules inopen-sse/services/compression/rules/ru/*.jsoncould never match Cyrillic (tokensSaved ~0). The detector's ru keyword regex had the same dead\b(masked by a catch-all Cyrillic hint).Fix
Replaced
\bwith(?<![\p{L}\p{N}_])/(?![\p{L}\p{N}_])and setgiuon affected ru rules (dedup\w+->[\p{L}\p{N}_]+); same fix for the ru detector keyword hint. Patterns remain bounded (no new quantifier nesting).Not included (follow-up): user-level pack dir
~/.omniroute/compression/ruleslookup in ruleLoader (docs mismatch), and the same\bissue in es/pt-BR/it/fr/de packs.Tests
tests/unit/compression/ru-cyrillic-word-boundary-15677.test.ts(new). RED on unfixed code per triage probe (pleasantries rule left "Конечно, вот ответ." unchanged; detector keyword regex false); GREEN now (5/5). 12 related compression/detector test files: 104/104 pass.Gates
file-size, complexity, cognitive-complexity, eslint, typecheck:core, compression-budget, pre-commit hooks.