Repository navigation
fix(codex): honor the ultra alias set for parenthesized suffixes - #15710
Merged
diegosouzapw merged 1 commit intoOct 7, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
Pre-existing: the parenthesized form `model(ultra)` was validated against CODEX_MAX_ALIAS_MODELS regardless of the captured effort, so a max-only model like gpt-6-luna accepted `(ultra)` while the hyphenated `gpt-6-luna-ultra` was correctly rejected. Select the alias set by the captured effort value for both syntaxes. Signed-off-by: Minxi Hou <houminxi@gmail.com>
diegosouzapw
merged commit Oct 7, 2026
81cd353
into
diegosouzapw:release/v3.8.52
27 of 51 checks passed
This was referenced Oct 8, 2026
diegosouzapw
added a commit
that referenced
this pull request
Oct 8, 2026
Drains 9 v3.8.52 tip unit reds: 1 production fix (combo family-fallback skipped for request-scoped refusals, regression of #13603) + 8 test alignments to intentional contract changes (#15301 #15132 #15035 #15478 #15310 #15710 #15487), each annotated. Validated on a combined board with #15902 after clean npm ci: 32 previously-red files 327/329 (remaining 2 = quality-rail-gate-membership owned by #15682, and route-namespaces fixed in #15902), typecheck/open-sse/api typecheck, lint, 22 gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model(ultra)was checked againstCODEX_MAX_ALIAS_MODELSno matter which effort the parentheses captured. A max-only model such asgpt-6-lunatherefore accepted(ultra), while the hyphenatedgpt-6-luna-ultrawas already rejected. Both spellings now pick the alias set from the captured effort.Test
gpt-6-luna(ultra)andgpt-6-luna-ultrastay unresolved.gpt-6-luna(max)still splits, because luna is in the max set.