Repository navigation
chore(ci): clear inherited JSX and OIDC test lint violations - #15693
Merged
diegosouzapw merged 1 commit intoOct 7, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
3 of 4 tasks
diegosouzapw
merged commit Oct 7, 2026
cdd9a02
into
diegosouzapw:release/v3.8.52
28 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clear two lint violations inherited from
release/v3.8.52: escape the apostrophe in the search-timeout help text inRoutingTab.tsx, and replace the OIDC test helper's explicitanyresponse cast with the optional error-code shape its assertions inspect. The UI displays the same text and the OIDC runtime assertions are unchanged. Prettier also normalized the adjacent timeout-provider map formatting.Related Issues
Validation
npm run lint— passed (0 errors).release/v3.8.52snapshot6fed1939ec; no unrelated working-tree changes.Evidence:
RoutingTab.tsx:1534:65(react/no-unescaped-entities) andoidc-settings-allowlist-guard.test.ts:33:70(no-explicit-any). Both files are unchanged by fix(api): preserve custom-node combo catalog metadata after builder saves #15668.node --import tsx/esm --import ./open-sse/utils/setupPolyfill.ts tests/unit/oidc-settings-allowlist-guard.test.ts— 5 passed.npm run typecheck:core— passed.npm run check:file-size -- --base-ref 6fed1939ec028c1de958aa625390984167f95892— passed.Full unit, Vitest/UI, coverage, and build gates remain CI validation. SonarQube is opt-in, not a PR gate.
Tests Added Or Updated
tests/unit/oidc-settings-allowlist-guard.test.ts: narrows the response helper type without changing its five real route/database assertions for the OIDC allowlist guard.Coverage Notes
No production logic or branch changed. The JSX entity preserves the rendered text. Existing OIDC tests exercise their original behavior; no baseline or suppression change. Coverage measurement remains with CI.
Reviewer Notes