Skip to content

chore(ci): clear inherited JSX and OIDC test lint violations - #15693

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.52from
ekinnee:fix/release-v3.8.52-basereds-lint
Oct 7, 2026
Merged

diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.52from
ekinnee:fix/release-v3.8.52-basereds-lint

Conversation

@ekinnee

@ekinnee ekinnee commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Clear two lint violations inherited from release/v3.8.52: escape the apostrophe in the search-timeout help text in RoutingTab.tsx, and replace the OIDC test helper's explicit any response cast with the optional error-code shape its assertions inspect. The UI displays the same text and the OIDC runtime assertions are unchanged. Prettier also normalized the adjacent timeout-provider map formatting.

Related Issues

Validation

  • Change type: other — lint maintenance, no behavior change.
  • Focused tests/category gates from the Contribution Golden Path.
  • npm run lint — passed (0 errors).
  • Based on active upstream release/v3.8.52 snapshot 6fed1939ec; no unrelated working-tree changes.
  • Production-code changes include an updated automated test in this PR.

Evidence:

  • Before the repair, full lint on the exact base snapshot reported RoutingTab.tsx:1534:65 (react/no-unescaped-entities) and oidc-settings-allowlist-guard.test.ts:33:70 (no-explicit-any). Both files are unchanged by fix(api): preserve custom-node combo catalog metadata after builder saves #15668.
  • node --import tsx/esm --import ./open-sse/utils/setupPolyfill.ts tests/unit/oidc-settings-allowlist-guard.test.ts — 5 passed.
  • npm run typecheck:core — passed.
  • Prettier and whitespace checks passed; independent read-only review found no blocking defects.
  • npm run check:file-size -- --base-ref 6fed1939ec028c1de958aa625390984167f95892 — passed.

Full unit, Vitest/UI, coverage, and build gates remain CI validation. SonarQube is opt-in, not a PR gate.

Tests Added Or Updated

  • tests/unit/oidc-settings-allowlist-guard.test.ts: narrows the response helper type without changing its five real route/database assertions for the OIDC allowlist guard.

Coverage Notes

No production logic or branch changed. The JSX entity preserves the rendered text. Existing OIDC tests exercise their original behavior; no baseline or suppression change. Coverage measurement remains with CI.

Reviewer Notes

@ekinnee
ekinnee requested a review from diegosouzapw as a code owner October 6, 2026 22:26
@diegosouzapw
diegosouzapw merged commit cdd9a02 into diegosouzapw:release/v3.8.52 Oct 7, 2026
28 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants