Repository navigation
Conversation
3 of 4 tasks
Contributor
Author
|
Superseded by #15668, which carries the same reviewed repair on the repository-required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom-provider combo steps built by the dashboard store the internal node ID in
providerIdand its public prefix inmodel, for exampleproviderId: "openai-compatible-chat-…"withmodel: "cliproxy-direct/gpt-5.6-luna". The catalog treated the qualified string as the bare model ID, losing output limits, modalities, and reasoning tiers. This also affects already-saved steps after the builder prefix fix in #14143 (related to #14135).Normalize the public model prefix to the internal node ID before the catalog's existing target resolver strips it. Apply this only when the existing prefix winner map identifies the same node, preserving reserved-prefix and collision handling. Connection identity remains keyed to the node UUID. No persisted combo rewrite is needed for the affected UUID/public-prefix shape.
The regression builds global-picker and manual-entry steps through the real builder, persists them in an isolated database, and checks catalog metadata parity with the direct model. It also covers legacy UUID-qualified steps and rejects foreign-prefix reasoning metadata. Before the fix, the new regression failed with combo context 400000 versus direct context 1050000; after the fix all 14 tests in the metadata file pass.
Validation:
node --import tsx/esm --import ./open-sse/utils/setupPolyfill.ts tests/unit/models-catalog-combo-metadata.test.ts— 14 passed.npm run test:vitest— 54 files / 493 tests passed.npm run typecheck:core, focused ESLint, Prettier check, and diff whitespace check passed./v1/modelsis outside this patch's scope.